1814749 - Do not endlessly recreate MF CDM process when it's crashed

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, task, P2)

Description

[Alastor Wu [:alwu]]

In bug 1808804, we implemented a way to recover playback, but we should set a threshold for retry amount. If the MFCDM process keeps crashing, then we would fallback to the normal playback pipeline and stop trying to use media engine pipeline.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1814749 - part1 : create a simple helper to monitor the amount of crash of the remote process.

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1814749 - part1 : do not recover the CDM process from crash unlimitedly.

Depends on D173238

Comment 3

[Alastor Wu [:alwu]]

Attachment: Bug 1814749 - part2 : do not call engine method until the recovery finishes.

Depends on D173240

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1814749 - part3 : add a test.

Depends on D173374

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8eb0d7b8b65
part1 : do not recover the CDM process from crash unlimitedly. r=jolin
https://hg.mozilla.org/integration/autoland/rev/babe4bfab4f7
part2 : do not call engine method until the recovery finishes. r=jolin
https://hg.mozilla.org/integration/autoland/rev/84c7cbeaccd6
part3 : add a test. r=jolin

Comment 6

[Marian-Vasile Laza]

Backed out 3 changesets (Bug 1814749) for build bustages on ExternalEngineStateMachine.cpp.
Backout link
Push with failures <--> Bip
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d875d0efc8d7
part1 : do not recover the CDM process from crash unlimitedly. r=jolin
https://hg.mozilla.org/integration/autoland/rev/13ce54d6bdc7
part2 : do not call engine method until the recovery finishes. r=jolin
https://hg.mozilla.org/integration/autoland/rev/7582e5c56f4a
part3 : add a test. r=jolin

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d875d0efc8d7
https://hg.mozilla.org/mozilla-central/rev/13ce54d6bdc7
https://hg.mozilla.org/mozilla-central/rev/7582e5c56f4a