1814862 - Build ICU with UCONFIG_NO_BREAK_ITERATION

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement)

Description

[Henri Sivonen (:hsivonen)]

AFAICT, we don't use ICU4C break iteration directly. Indirectly, we depend on it via the ICU4C formatters' capability to do contextual capitalization of the formatted string, but, AFAICT, contextual capitalization isn't actually reached via ECMA-402. (Am I right?)

Building with UCONFIG_NO_BREAK_ITERATION saves 112 KB in libxul size on aarch64 Android and 123 KB on x86_64 Linux. I expect similar numbers for other targets.

Unlike the other formatters, the relative datetime formatter doesn't deal UCONFIG_NO_BREAK_ITERATION gracefully, but it's an easy thing to patch, and a bug that should be fixed in the upstream ICU4C anyway.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1814862 - Build ICU with UCONFIG_NO_BREAK_ITERATION

Comment 2

[Henri Sivonen (:hsivonen)]

https://treeherder.mozilla.org/jobs?repo=try&revision=0a7c3a9498b444fb6778f53096f19a271a55d910

Comment 3

[Henri Sivonen (:hsivonen)]

All try pushes need rebasing. Rebased:
https://treeherder.mozilla.org/jobs?repo=try&revision=9de8f267ce41df8a240c4eb84380584dcf922010

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hsivonen, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 5

[Henri Sivonen (:hsivonen)]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #4)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hsivonen, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

The patch here is r+'ed as accepting the upstream patch once it lands. The upstream PR is https://github.com/unicode-org/icu/pull/2303 . If that lands while I'm away from Bugzilla, I'm OK with someone else taking the upstream patch to m-c.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/198c66cc18eb
Build ICU with UCONFIG_NO_BREAK_ITERATION r=anba

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/198c66cc18eb