1815028 - creating saved search adds the virtual folder twice

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Magnus Melin [:mkmelin]]

File | New | Saved Search.
Enter a criteria and name the folder "test". After Ok, you now have two "test" folders showing - one marked as virual folder and one as normal folder. After restart both are marked as virtual, though of course there should only be one.

Comment 2

[Geoff Lankow (:darktrojan)]

Still seeing this?

Comment 3

[Wayne Mery (:wsmwk)]

With 112 2023-03-13 I see two folders, one has the special virtual folder icon, and one does not

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1815028 - Avoid duplicate folders appearing in the tree if onFolderAdded is called twice. r=mkmelin,aleca

When virtual folders are created, onFolderAdded is called a second time.

Rows should not be added to the tree if they already exist, but they should have their properties updated (in this case to add the "virtual" folder type).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b74f8c08ebc4
Avoid duplicate folders appearing in the tree if onFolderAdded is called twice. r=mkmelin,aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9322910 [details]
Bug 1815028 - Avoid duplicate folders appearing in the tree if onFolderAdded is called twice. r=mkmelin,aleca

[Triage Comment]
Approved for beta

Comment 7

[Daniel Darnell [:dandarnell]]

Thunderbird 112.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/b8bfd32eb467