1815051 - nsIAlertsService.showAlertNotification has issues with long title

Status: RESOLVED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect)

Description

[kernp25]

Attachment: Wgf2sdoscq.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

Install the test add-on.

Actual results:

Long title gets not rendered correctly (outside the box).

Expected results:

Should maybe truncate the title?
If i put the long title in the message body then everything works as expected.

Comment 1

[kernp25]

Attachment: background.zip

Comment 2

[kernp25]

I put this bug to Notifications and Alerts because notifications.create just calls svc.showAlertNotification.

Comment 3

[kernp25]

Maybe you have an idea how to fix this bug?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Yeah, this is probably a regression, the alert title is supposed to be closed here.

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1815051 - Use modern flexbox emulation for xul alerts. r=Gijs

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1815051 - Only override system colors on light mode. r=Gijs

This makes the alert follow prefers-color-scheme properly.

Depends on D168896

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/725fe51a1081
Use modern flexbox emulation for xul alerts. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/1600e96bb4af
Only override system colors on light mode. r=Gijs

Comment 8

[Cristian Tuns]

Backed out for causing multiple failures (sorry for the wrong commit message)

• Backout link
• Push with failures
• Failure Log
• Failure line: [taskcluster:error] [mounts] Could not fetch from task EJCj4F1_QAGzTFjQnARQEw artifact public/build/mozharness.zip into file Z:\downloads\Dt7OR7-gQEaDAA2yNBzneg due to open Z:\downloads\Dt7OR7-gQEaDAA2yNBzneg: The system cannot find the path specified.
  [taskcluster:error] [mounts] open Z:\downloads\Dt7OR7-gQEaDAA2yNBzneg: The system cannot find the path specified.

log 2 https://treeherder.mozilla.org/logviewer?job_id=404850457&repo=autoland

log 3: https://treeherder.mozilla.org/logviewer?job_id=404850533&repo=autoland

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e6897140088
Use modern flexbox emulation for xul alerts. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/ecb8b141c22b
Only override system colors on light mode. r=Gijs CLOSED TREE

Comment 10

[Cristian Tuns]

This got relanded, it looks like that is caused by something else. Sorry for the inconvenience

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/2e6897140088
https://hg.mozilla.org/mozilla-central/rev/ecb8b141c22b