1815235 - [traceback] TypeError: "sequence item 0: expected str instance, float found" in SignatureShutdownTimeout

Status: RESOLVED FIXED

(Socorro :: Processor, defect, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry: https://sentry.io/organizations/mozilla/issues/3916292491/

Traceback:

TypeError: sequence item 0: expected str instance, float found
  File "socorro/signature/generator.py", line 140, in generate
    rule.action(signature_data, result)
  File "socorro/signature/rules.py", line 951, in action
    parts.append(",".join(conditions))

In SignatureShutdownTimeout, the async_shutdown_timeout can sometimes have an unexpected shape where the conditions aren't strings, but rather floats.

Example: dd655cf6-2898-438a-9205-653290230204

The name is:

"name":2.032988e-315

I think we should stringify the value and then we're "ok".

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

This is a straight-forward fix. Grabbing it now.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6344: bug 1815235: stringify cond names in SignatureShutdownTimeout rule

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6344: "bug 1815235: stringify cond names in SignatureShutdownTimeout rule" in 43a92ed.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

I deployed this just now in bug #1819758. Marking as FIXED.