1815248 - Remove setParameters compat mode forgiveness of rid changes

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, task)

Description

[Byron Campen [:bwc]]

While we have observed the other warnings pretty frequently, our telemetry has never observed this warning code occur:

https://searchfox.org/mozilla-central/rev/ddbeacddc15008936e8f619c8c3a05fac6eab8d8/dom/media/webrtc/jsapi/RTCRtpSender.cpp#558-563

It is probably safe to remove this.

Comment 1

[Byron Campen [:bwc]]

It probably also makes sense to remove the failure telemetry for this error, but maybe we leave that in place for a little while longer, just in case.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1815248: Stop letting rid changes slide in setParameters. r?jib

This warning is not happening in the field at all, so we can tighten
this up.

Comment 3

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=07a59a306ec8ff25fc60ee07f9ca145582f82dea
https://treeherder.mozilla.org/jobs?repo=try&revision=ae4f53c683c120afa8a5b6a6ffb43d9417c7a4cd

Comment 4

[Byron Campen [:bwc]]

Try looks fine so far, just waiting on the huge test backlog on macos.

Comment 5

[Byron Campen [:bwc]]

Try looks good.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9ba1293f158
Stop letting rid changes slide in setParameters. r=jib

Comment 7

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1404d9226578
Stop letting rid changes slide in setParameters. r=jib

Comment 9

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9631987e5582
Stop letting rid changes slide in setParameters. r=jib

Comment 12

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/9631987e5582