1815255 - Enable flexbox emulation everywhere (on nightly-only for now)

Status: RESOLVED FIXED

(Core :: XUL, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815255 - Enable flexbox emulation on nightly. r=Gijs

This only affects pages that don't enable it explicitly (so places
window, etc).

The main browser area and all in-content pages (plus a few other windows
etc) already enable it explicitly.

I took care of the issues I found, let's find the remaining issues, if
any, sooner rather than later.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8900b580582c
Enable flexbox emulation on nightly. r=Gijs

Comment 3

[Cristian Tuns]

Backed out for causing multiple mochitest failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/hyperlink/test_general.xhtml | wrong extra state bits for ['label@id="linkLabelWithValue" node', address: [object XULTextElement], role: link, name: 'Mozilla Foundation', address: [xpconnect wrapped (nsIAccessible, nsIAccessibleHyperLink)]]!got '0', expected 'horizontal'

Failure log 2: https://treeherder.mozilla.org/logviewer?job_id=404854431&repo=autoland

Reftest log: https://treeherder.mozilla.org/logviewer?job_id=404850682&repo=autoland

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815255 - Fix tests to deal with flexbox emulation. r=Gijs,#layout

Mostly changing XUL attributes to CSS properties.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/jobs?repo=try&revision=c05a1321149d764200a6613c5db161e9a9fe5c5e

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8c6426c60f9
Fix tests to deal with flexbox emulation. r=Jamie,Gijs
https://hg.mozilla.org/integration/autoland/rev/983fe4e70647
Enable flexbox emulation on nightly. r=Gijs

Comment 7

[Cristina Horotan [:chorotan]]

Backed out 2 changesets (bug 1815255) for causing chrome failures at test_focus.xhtml

Backout: https://hg.mozilla.org/integration/autoland/rev/3ceafd5142ccd9f7dc3d395385f64679f47fd812

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=983fe4e70647d73d2977c3501ec19a33737bd6b7&selectedTaskRun=WyMIZsP_TSm_vTfbFxvc9g.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=405032320&repo=autoland&lineNumber=4214
https://treeherder.mozilla.org/logviewer?job_id=405033109&repo=autoland&lineNumber=3542

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd09cf2a4abb
Fix tests to deal with flexbox emulation. r=Jamie,Gijs
https://hg.mozilla.org/integration/autoland/rev/b1173e8c7497
Enable flexbox emulation on nightly. r=Gijs

Comment 9

[Marian-Vasile Laza]

Backed out 2 changesets (Bug 1815255) for causing reftest failures.
Backout link
Push with failures <--> R5 <--> R2
Failure Log R5
Failure Log R2

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/772e1fb7bf58
Fix tests to deal with flexbox emulation. r=Jamie,Gijs
https://hg.mozilla.org/integration/autoland/rev/62fd688e3359
Enable flexbox emulation on nightly. r=Gijs

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/772e1fb7bf58
https://hg.mozilla.org/mozilla-central/rev/62fd688e3359