Closed Bug 1815271 Opened 1 year ago Closed 1 year ago

Event::GetType could avoid allocations when GetEventName(mMessage) returns a non-null value

Categories

(Core :: DOM: Events, enhancement)

Product:
Core
Component:
DOM: Events
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(1 file)

Bug 1815271 - Event::GetType could avoid allocations when GetEventName(mMessage) returns a non-null value, r=masayuki
48 bytes, text/x-phabricator-request
Details | Review

Right now GetEventName's return value is assigned to aType, but it could use AssignLiteral and avoid allocation. I had one performance profile where this showed up a very tiny bit, but lost the link.

patch coming

Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b34aa4502224
Event::GetType could avoid allocations when GetEventName(mMessage) returns a non-null value, r=masayuki

https://hg.mozilla.org/mozilla-central/rev/b34aa4502224

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: