Fix preprocessor define for ARM64 macOS.
Categories
(Core :: Graphics: CanvasWebGL, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr102 | --- | unaffected |
firefox109 | --- | unaffected |
firefox110 | + | fixed |
firefox111 | + | fixed |
People
(Reporter: jrmuizel, Assigned: jrmuizel)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
dmeehan
:
approval-mozilla-release+
|
Details | Review |
ARM64 is only defined on Windows. Use JS_CODEGEN_ARM64 instead.
Assignee | ||
Comment 1•1 year ago
|
||
ARM64 is only defined on Windows. Use JS_CODEGEN_ARM64 instead.
Pushed by jmuizelaar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/74dfd4c941f5 Fix preprocessor define for ARM64 macOS. r=gfx-reviewers,jnicol
Assignee | ||
Comment 3•1 year ago
|
||
Comment on attachment 9316168 [details]
Bug 1815278 - Fix preprocessor define for ARM64 macOS.
Beta/Release Uplift Approval Request
- User impact if declined: Users will experience hangs in Google meet on ARM64 macOS. These hangs affect WebGL permanently and require a machine reset to kill the hung Firefox process
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Medium
- Why is the change risky/not risky? (and alternatives if risky): This disables a webgl fast path. The biggest risk is performance, but it's possible there could be some correctness issues because we're taking a different path.
String changes made/needed: - String changes made/needed:
- Is Android affected?: No
Comment 4•1 year ago
|
||
Comment on attachment 9316168 [details]
Bug 1815278 - Fix preprocessor define for ARM64 macOS.
Approved for 110 RC1
Comment 5•1 year ago
|
||
uplift |
Updated•1 year ago
|
Comment 6•1 year ago
|
||
bugherder |
Updated•1 year ago
|
Comment 7•1 year ago
•
|
||
I was not able to reproduce this issue on mac 11, 12 and 13 ARM using Firefox 110 (build from 6 feb), Nightly 111(builds from 4, 5 and 6 feb) with Google Meet (30m) and WebGL (https://www.awwwards.com/websites/webgl/). Please add the steps to reproduce this bug if there is anything we can do.
Assignee | ||
Comment 8•1 year ago
|
||
(In reply to Ralu from comment #7)
I was not able to reproduce this issue on mac 11, 12 and 13 ARM using Firefox 110 (build from 6 feb), Nightly 111(builds from 4, 5 and 6 feb) with Google Meet (30m) and WebGL (https://www.awwwards.com/websites/webgl/). Please add the steps to reproduce this bug if there is anything we can do.
Assignee | ||
Comment 9•1 year ago
|
||
Steps to reproduce on ARM64 macOS:
- Start a google meet meeting with an animated virtual background
- Wait for a while.
Comment 10•1 year ago
|
||
Still not able to reproduce the issue on macOS 11.6.8 ARM
- Started a google meet with an animated virtual background on Chrome because Firefox doesn't support effects.
- Join the same meet from Firefox.
- Wait for 3 hours.
Actual result: Firefox works as expected(no hangs, no freezing)
Description
•