Closed Bug 1815288 Opened 2 years ago Closed 2 years ago

Quick filters not working since the upgrade to 102.7.1, and Quick filter bar vanished (deleting session.json helps)

Categories

(MailNews Core :: Search, defect)

Product:
MailNews Core
Component:
Search
Version:
Thunderbird 102
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1745007

People

(Reporter: info, Unassigned)

Details

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/109.0

Steps to reproduce:

I upgraded to TB 102.7.1 from the most recent previous release version.

Actual results:

Immediately after the upgrade, entering search terms in the Quick filter bar did not effect anything. No filtering happened. After a restart of TB, the Quick filter bar has vanished, and I cannot make it reappear via "View -> Toolbars -> Quick Filter Bar".

This has happened with multiple TB installations on different PCs.

Expected results:

The Quick Filter Bar should have worked as in the previous versions, and it should not have disappeared.

(In reply to Binarus from comment #0)

I probably should have mentioned that we have switched to maildir here several months ago. Could this be an issue?

I know that maildir isn't supported officially (yet), but mbox was so slow that it was near to unusable in certain situations. maildir solved that problem in an impressive way.

Seems to work fine for me. Could some add-on be causing it? Try Help | Troubleshoot mode

wfm on TB 102.7.1 (64-bit), Win10, gmx-IMAP with maildir. Might have jumped 102.7.0, but also updated to 102.7.1.

Binarus,

  • As comment 2 suggests, pls try ≡ > Help > Troubleshoot Mode…
  • Anything in Tools > Developer Tools > Error Console (Ctrl/Cmd+Shift+J)?
  • You may also want to start TB with -purgecaches parameter
  • You can try right-click on folder > Properties > Repair Folder, or backing up and deleting .msf files in the respective profile folder.
  • Have you tried other methods of restoring the Quick Filter Bar? What about the Quick Filter button on Mail toolbar?

If we find something which allows us to reproduce, we can reopen this bug.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago
Component: Untriaged → Search
Flags: needinfo?(info)
Product: Thunderbird → MailNews Core
Resolution: --- → WORKSFORME

(In reply to Magnus Melin [:mkmelin] from comment #2)

Seems to work fine for me. Could some add-on be causing it? Try Help | Troubleshoot mode

Thank you very much for the hint. I have followed your advice, but the result was surprising:

In troubleshoot mode, I can see the menu item "View -> Toolbars -> Quick Filter Bar", but "Quick Filter Bar" is greyed out, so I can't activate it. Additionally, the "Quick Filter" button on the Mail toolbar is now greyed out as well.

In normal mode, the "Quick Filter Bar" menu item and the "Quick Filter" button were not greyed out, but didn't effect anything. I can't tell if they would effect anything in troubleshoot mode, because as explained above they are greyed out.

Flags: needinfo?(info)

(In reply to Thomas D. (:thomas8) from comment #3)

wfm on TB 102.7.1 (64-bit), Win10, gmx-IMAP with maildir. Might have jumped 102.7.0, but also updated to 102.7.1.

Binarus,

  • As comment 2 suggests, pls try ≡ > Help > Troubleshoot Mode…

Please see my reply to @mkmelin's comment. The behavior in troubleshoot mode is surprising.

  • Anything in Tools > Developer Tools > Error Console (Ctrl/Cmd+Shift+J)?

I'll check that and report back.

  • You may also want to start TB with -purgecaches parameter

I'll try to learn what that parameter does and will try it.

  • You can try right-click on folder > Properties > Repair Folder, or backing up and deleting .msf files in the respective profile folder.

I probably won't try the "Repair folder" method, because every folder is affected by the problem, and I have thousands of them. I'll delete every .msf file, though, and report what happens.

  • Have you tried other methods of restoring the Quick Filter Bar? What about the Quick Filter button on Mail toolbar?

In troubleshoot mode, the "Quick Filter" button is greyed out (see my previous comment). In normal mode, that button is not greyed out, but does not effect anything either.

If we find something which allows us to reproduce, we can reopen this bug.

Yes, that's understandable. I just was wondering why this happened all of a sudden just after the upgrade on multiple machines, and was quite sure that I am not the only user who encounters that problem.

(In reply to Thomas D. (:thomas8) from comment #3)

  • Anything in Tools > Developer Tools > Error Console (Ctrl/Cmd+Shift+J)?

Yes. I am getting several messages like those below:

aFilterValue is null QuickFilterManager.jsm:1331
    reflectInDOM resource:///modules/QuickFilterManager.jsm:1331
    reflectFiltererState chrome://messenger/content/quickFilterBar.js:288
    onTabRestored chrome://messenger/content/quickFilterBar.js:480
    restoreTab chrome://messenger/content/mailTabs.js:272
    restoreTab chrome://messenger/content/tabmail.js:1487
    restoreTabs chrome://messenger/content/tabmail.js:1508
    atStartupRestoreTabs chrome://messenger/content/msgMail3PaneWindow.js:1544
    InterpretGeneratorResume self-hosted:1422
    AsyncFunctionNext self-hosted:632

TypeError: aFilterValue is null
    reflectInDOM resource:///modules/QuickFilterManager.jsm:1331
    reflectFiltererState chrome://messenger/content/quickFilterBar.js:288
    onTabSwitched chrome://messenger/content/quickFilterBar.js:506
    updateCurrentTab chrome://messenger/content/tabmail.js:1700
    connectedCallback chrome://messenger/content/tabmail-tabs.js:588
    set selectedIndex chrome://messenger/content/tabmail-tabs.js:651
    closeTab chrome://messenger/content/tabmail.js:1216
    removeTabByNode chrome://messenger/content/tabmail.js:1245
    connectedCallback chrome://messenger/content/tabmail-tab.js:98
tabmail.js:1702:21

Uncaught TypeError: aState is null
    onCommand resource:///modules/QuickFilterManager.jsm:1273
    handler chrome://messenger/content/quickFilterBar.js:241
    _fireCommand chrome://global/content/elements/search-textbox.js:230
    _enterSearch chrome://global/content/elements/search-textbox.js:248
    on_keypress chrome://global/content/elements/search-textbox.js:211
    handleEvent chrome://global/content/customElements.js:466
QuickFilterManager.jsm:1273:9
  • You may also want to start TB with -purgecaches parameter

To be done ...

  • You can try right-click on folder > Properties > Repair Folder, or backing up and deleting .msf files in the respective profile folder.

I have closed TB, deleted all .msf files and restarted TB in normal mode. Deleting the .msf files did not change anything. The Quick Filter Bar is there again, and I can enter search terms into it, but there is no reaction to any keystroke, including <ENTER>.

  • Have you tried other methods of restoring the Quick Filter Bar? What about the Quick Filter button on Mail toolbar?

Clicking on that button does not bring up the Quick Filter Bar if it is not currently visible, and does not make it disappear if it is currently visible. This is the same behavior as with the menu item "View -> Toolbars -> Quick Filter Bar".

Perhaps I'll reinstall or create a new profile. I am using the Quick Filter Bar very often; it is an essential tool for me.

Interestingly, the global search works without any issue.

Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---

I have reopened the bug in the hope that somebody can spot the problem from the error messages above.

See bug 1745007 comment 9.

Status: UNCONFIRMED → RESOLVED
Closed: 2 years ago → 2 years ago
Duplicate of bug: 1745007
Resolution: --- → DUPLICATE

@mkmelin

Thanks for bringing the duplicates to my attention.

For reference, I found the solution in the comments in the duplicate bug reports. After having deleted session.json from my profile, everything went back to normal. In my case, I didn't need to delete xulstore.json (as advised elsewhere).

However, I am wondering why the duplicate bugs have been closed with "worksforme". According to the reports, there are several people affected by the problem.

It's not believed to be caused by Thunderbird core. Likely something an add-on left somewhere.
We don't know - if you figure it out please let us know. If we know what the problem is maybe there is something we can do to mitigate it.

I see. Thank you very much for the explanation.

I now have looked into one of the session.json files that caused the problem; see below. Obviously, neither the curly nor the square brackets match, so it's no wonder that TB gets worried when processing that file. I have no clue what could have caused the bad state and wrong syntax, though. We are using the same add-ons since months and are using them again right now (after our tests with the troubleshoot mode) without any problems.

Thanks, and best regards.

{
  "rev":0
  "windows":[
    {
      "type":"3pane"
      "tabs":{"rev":0
      "selectedIndex":3
      "tabs":[
      {
        "mode":"folder"
        "state":{"folderURI":"imap://xxxxxx@imap.mail.example.de/INBOX"
        "folderPaneVisible":true
        "messagePaneVisible":false
        "firstTab":true
      }
      "ext":
      {
        "quickFilter":
        {
          "filterValues":{}
          "visible":true
        }
      }
    }
    {
      "mode":"message"
      "state":{"messageURI":"imap-message://xxxxxx@imap.mail.example.de/INBOX#316484"}
      "ext":{}
    }
    {
      "mode":"message"
      "state":{"messageURI":"imap-message://xxxxxx@imap.mail.example.de/INBOX#316485"}
      "ext":{}                              
    }                                       
    {                                       
      "mode":"message"                      
      "state":{"messageURI":"imap-message://xxxxxx@imap.mail.example.de/INBOX#316411"}
      "ext":{}
    }
  ]
}
}
]
}

@mkmelin

Unfortunately, we couldn't solve this problem, and it is becoming a real pain, and the bug should be re-opened due to the following situation:

Deleting session.json as described above still brings things back to normal. However, TB then screws the syntax of that file again, typically within a day or so. That means that we currently need to delete session.json once a day.

I am really not that deep in TB, but I tend to believe that TB is the culprit, not one of the addons. This is because the content of session.json is always nearly the same as the code in my previous post shows, and I can't see any evidence there that an addon has put rubbish into it. Instead, every entry seems to come from TB itself.

It's only the kind of syntax error that differs: One time it's the curly braces that don't match, one time it's the square brackets. But every time, it's the braces / brackets.

Could you eventually have a look at the places in the code where session.json is written? Perhaps you'll notify something at first glance that can be fixed without extreme effort.

Until then, we'll probably make a script that cleans session.json on a regular basis, but that isn't as easy as it seems because that script probably must verify that TB is not running before taking any action.

I don't see anything obvious. But much of this code has changed since 102 so there's a good chance it would be gone.

Summary: Quick filters not working since the upgrade to 102.7.1, and Quick filter bar vanished → Quick filters not working since the upgrade to 102.7.1, and Quick filter bar vanished (deleting session.json helps)

Bug 1823272 indicates maybe due to the CardBook add-on. Using that?

You need to log in before you can comment on or make changes to this bug.