1815309 - Menus in permission doorhangers open on hover rather than click

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Paul Zühlcke [:pbz]]

Attachment: perm-doorhanger-menu-hover.jpg

Tested on macOS + Nightly 111.0a1 (2023-02-06) (64-bit)

STR:

1. Open https://permission.site
2. Click on the "Screen Share" button
3. In the permission doorhanger that opens mouse hover over the expand arrow of the "block" button.

Expected:
Nothing happens unless you click the arrow panel

Actual:
On hover the menu opens

Mozregression:

16:17.49 INFO: Last good revision: 0c989b2bcd7882a9e7106e7879ab8933c2e09071
16:17.49 INFO: First bad revision: 47c002d3637247e71ee901f32421deaecc9d8ea3
16:17.49 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0c989b2bcd7882a9e7106e7879ab8933c2e09071&tochange=47c002d3637247e71ee901f32421deaecc9d8ea3

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1805414

Comment 2

[Emilio Cobos Álvarez (:emilio)]

This also happens on Windows and probably Linux. It's basically a similar thing as bug 1809019.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815309 - Make IsOnMenu() only return true for menupopups/popup elements. r=smaug

This matches what the old code did.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

So what does the DOM tree look like here? Why does the menu open?

Comment 5

[Emilio Cobos Álvarez (:emilio)]

There's a <button type="menu"> inside a <panel>. So if we treat the panel as a menu, the <button> opens because of this

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc947b40e222
Make IsOnMenu() only return true for menupopups/popup elements. r=smaug

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1815309 - Test. r=smaug

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e8aaa2cf79a
Test. r=smaug

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bc947b40e222

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6e8aaa2cf79a

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9316229 [details]
Bug 1815309 - Make IsOnMenu() only return true for menupopups/popup elements. r=smaug

Beta/Release Uplift Approval Request

• User impact if declined: comment 0
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fix to preserve old behavior.
• String changes made/needed: none
• Is Android affected?: No

Comment 13

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Reproduced the issue with Firefox 111.0a1 (2023-2-06) on Windows 10x64. The menu opens on hover after following the steps from comment 0.
The issue is verified fixed with Firefox 111.0b2 on Windows 10x64 and macOS 12. The menu no longer opens on hover.

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9316311 [details]
Bug 1815309 - Test. r=smaug

Hitting this bug seems an infrequent scenario, let's have it in 111 in two weeks, thanks!