Closed Bug 1815344 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38378 - Add missing null check in FormData constructor

Categories

(Core :: DOM: Networking, task, P4)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38378 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38378
Details from upstream follow.

Jon Jensen <jonj@netflix.com> wrote:

Add missing null check in FormData constructor

Regression from https://chromium-review.googlesource.com/c/chromium/src/+/4189297

Fix a crash when form is explicitly undefined and a submitter
argument is given, e.g. new FormData(undefined, null);. Prior to
adding the new submitter argument, a crash was not possible, as the
v8 bindings would only ever call the Create(exception_state) overload
when form was explicitly undefined.

Bug: 1412970
Change-Id: I3f98ca2d4648ccbcc5641068d768960e28f059f4
Reviewed-on: https://chromium-review.googlesource.com/4226035
WPT-Export-Revision: ad98fe932bcb4eae1398221a6ddf768212e62b27

Component: web-platform-tests → DOM: Networking
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
PASS: 9

Chrome

OK : 1
PASS: 3
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/324b398d0128 [wpt PR 38378] - Add missing null check in FormData constructor, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.