1815349 - [wpt-sync] Sync PR 38381 - [GridNG] Clamp auto-placement to subgrid area

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38381 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38381
Details from upstream follow.

Kurt Catti-Schmidt (SCHMIDT) <[e-mail]> wrote:

[GridNG] Clamp auto-placement to subgrid area

While prototyping auto-repeat for subgrids, I came across a subtle
placement bug with subgrids that's a sub-case of
repeat-auto-fill-001.html.

In summary, auto placement for grids depends on minor_max_end_line_,
which determines when to wrap lines. For normal grids this can extend
indefinitely, and implicit tracks will be created to fit the expanded track numbers. However, for subgrids, this can be at maximum the
subgrid span size. Implicit tracks can be created for subgrids, but
only up to the subgrid span size.

Prior to this change, we were only clamping at the very end of
placement, which was causing various "double-placement" issues,
demonstrated in the test case added.

Bug: 618969
Change-Id: Ic3972408e4dd4f2069fa1bf26c95d815c26cb929

Reviewed-on: https://chromium-review.googlesource.com/4225602
WPT-Export-Revision: 6adaadbc13f209322c30aea2ae7bce41e64f3a8a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4e9605d1e008ee9b73f287dc73c0bff7dff54ec

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d31632e312a
[wpt PR 38381] - [GridNG] Clamp auto-placement to subgrid area, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2d31632e312a