Closed Bug 1815357 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38383 - Add tree scope hash into MatchedPropertiesCache key

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38383 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38383
Details from upstream follow.

Xiaocheng Hu <xiaochengh@chromium.org> wrote:

Add tree scope hash into MatchedPropertiesCache key

It is possible that two elements match exactly the same rules with the
exact same tree scope order numbers, but still have different
ComputedStyle because they contain different tree-scoped names and
references. MPC currently is not handling this case, causing incorrect
reusing of ComputedStyle, and therefore, tree-scoped name confusions.

This is fixed in this patch.

Fixed: 1413525
Change-Id: Ib686f26a1b08901b0746a6ff46ce0cbd559c39a1
Reviewed-on: https://chromium-review.googlesource.com/4226315
WPT-Export-Revision: 58fce807e265e4bb9d5dafe84b5f1d9028a90d3d

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3eee71c79dd3 [wpt PR 38383] - Add tree scope hash into MatchedPropertiesCache key, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.