181543 - Return code from Peek saved but not checked in nsScanner::ReadUntil

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P5)

Description

[Daniel Bratell]

As the summary says, the return code from calling Peek() in nsScanner::ReadUntil
is saved into a variable that is never checked. The result should either be
completely ignored or checked.

  PRUnichar theChar;
  nsresult  result=Peek(theChar);   // <--- right now, line 1338
  
  while (current != mEndPosition) {

Comment 1

[David Bradley]

It appears to be checked now. Looks like someone fixed it.

  nsresult  result=Peek(theChar);

  if (result == kEOF) {
    return Eof();
  }

Comment 2

[Christopher Hoess (gone)]

Wrong function. Look at the third ReadUntil: nsresult
nsScanner::ReadUntil(nsAString& aString,
                              PRUnichar aTerminalChar,
                              PRBool addTerminal)

This function doesn't have the check.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

This was fixed by the patch in bug 276149.