1815488 - History: Delete history > 3 dots > history > trashcan > incomplete

Status: NEW

(Firefox for Android :: History, defect)

Description

[notmyrealname]

Steps to reproduce:

1. Go to ... > Settings > Delete browsing data
2. select everything & delete it
3. open a website in normal mode (not private) for example https://metager.org/
4. select website menu > top right > "settings" > "web"
5. change/customize some settings and save it
6. close all the tab
7. reopen the website (make sure the settings are still changed/customized)
8. close all tabs (tab overview > three dots > "close all tabs")
9. open firefox menu (three dots) > history > trash can-symbol
10. in the prompt select "everything"
11. press delete
12. reopen the website (step 3) where the settings was changed

Actual results:

• the entries disappear (at history) when pressing delete

• the website settings are still customized

• the settings that was changed would not be deleted

Expected results:

As descriped in the prompt (step 10):

• it should remove history, cookies and other browsing data.

• for the selected time range

• the website should have no costomized settings

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Achintya Sharma]

what if all the data for that site is stored in a cookie , then deleting the history wont have effect on site's data. you'll have to add a function if you delete history the cookie should be deleted too, but that would be dangerous.

Comment 3

[Vlad Dreghici [:vdreghici]]

I managed to reproduce this issue in Nightly 114.0a1 with the exact steps given. Replacing step 9 with step 1 is actually leading to the expected result. I have also attached a video below

Comment 4

[Vlad Dreghici [:vdreghici]]

Attachment: Untitled(5).mp4

Comment 5

[Vlad Dreghici [:vdreghici]]

Upon investigating this issue for a while, I have noticed there is a difference on how history, cookies and other browsing data deletion is handled. When deleting everything from history, the operation goes through the PlacesHistoryStorage which is backed up by PlacesApi. On the other hand, when deleting browsing data from the browser menu and checking the "Browsing history and site data" + the "Cookies" checkboxes, for the first box, a similar operation is executed as before, but for the cookies part, they are deleted by clearing data from the engine implementation.

In the end, the question here is, do we want to change the message in the dialog when deleting history, such that it does not inform the user of deleting cookies anymore, or do we want to add the additional operation of deleting cookies when clearing history?

Comment 6

[Mike a [:mavduevskiy]]

Vlad, thanks for taking a look into this! You nailed down the problem perfectly: history screen and delete browsing data screens handle deleting differently. History screen doesn't actually remove cookies. The problem is, there is currently now way we could delete time range for cookies. clearData inside Gecko doesn't take in time ranges in consideration, something like deleteDataInTimeRange should be implemented there. So we can't add additional operation easely, it requires updating the GeckoView first.

Digging into designs, I managed to find the discussion where this copyright might have appeared. Let's consult the UX team how we should change the existing text – to communicate that we are removing just history. And if we should add removing cookies and other browsing data (does it mean all the data we store?) for a time frame.

Comment 7

[Mike a [:mavduevskiy]]

Hi! :topotropic

We run into a problem with this copyright. Our user has reported that cookies are not being deleted. And it's true: the android app can not delete those by a specific time frame, as of now.

How should we change the text, so we would not generate confusion for the users?
Should we add removing cookies and other data for this dialog as a follow up?

Comment 8

[Nicole Weber [:topotropic]]

Thanks for the ping! Do we have a follow up story to implement the feature in GeckoView?

And yes, we should definetely change the copy to mirror what is actually happening.
:emilyw, would you have time to look into this? here's the Figma https://www.figma.com/file/SO8Cd5lnmgNqJQY9KpORc9?node-id=879:41209#203118587

Comment 9

[Emily Wachowiak [:emilyw]]

:mavduevskiy Would it be more accurate to just say this: "Removes history (including history synced from other devices)."
Because if I understand this ticket correctly, we are NOT removing cookies and other browsing data. Did I get this right?

Comment 10

[Emily Wachowiak [:emilyw]]

Confirmed with :mavduevskiy that this suggestion will work.

Comment 11

[Mike a [:mavduevskiy]]

NB: as a mid step we are changing the text to reflect what the app is actually doing, until GeckoView provides the API to removing cookies and data within a time range. To the person that will be working on it: we want to switch back to the string that has been used prior to this change.

Comment 12

[Denis Müller [:Webworkr]]

Possibly related to bug 1869369.