Update all usages of lastModificationDate off of IOUtils.stat calls to use lastModified instead
Categories
(Firefox :: Migration, task, P3)
Tracking
()
People
(Reporter: mconley, Unassigned)
References
(Blocks 1 open bug)
Details
Our migrators used to use OSFile.jsm to do file IO. One of the functions used was OS.File.stat, which would return an object about a file saying things like when it was created, or last modified. The property for last modified date was lastModificationDate.
We've recently updated our migrators to use the (much better!) IOUtils.stat. We are, however, still trying to access lastModificationDate on the object that the stat call resolves to, except that it should be lastModified, and then we should convert that into a date. See https://searchfox.org/mozilla-central/rev/08362489086b10de96e7a199b267ea5504c01583/dom/docs/ioutils_migration.md#48-52.
Here are the places that need updating:
- https://searchfox.org/mozilla-central/rev/08362489086b10de96e7a199b267ea5504c01583/browser/components/migration/ChromeProfileMigrator.sys.mjs#141
- https://searchfox.org/mozilla-central/rev/08362489086b10de96e7a199b267ea5504c01583/browser/components/migration/IEProfileMigrator.sys.mjs#380
- https://searchfox.org/mozilla-central/rev/08362489086b10de96e7a199b267ea5504c01583/browser/components/migration/SafariProfileMigrator.sys.mjs#393
|
Reporter | |
Comment 1•1 year ago
|
||
Note that since the date isn't (currently) being used to sort the list of migrators, users aren't experiencing any pain here, but we'll eventually want to do that sorting, which is why we should fix this.
|
||
Updated•1 year ago
|
|
||
Comment 2•1 year ago
|
||
The severity field is not set for this bug.
:mconley, could you have a look please?
For more information, please visit auto_nag documentation.
|
|
Reporter | |
Updated•1 year ago
|
|
||
Comment 3•1 year ago
|
||
The search fox links here are out of date. Presently the only usage of .lastModificationDate is in ChromeProfileMigrator.sys.mjs: https://searchfox.org/mozilla-central/rev/3ede9deb876ad5d6389cb51b371d4a4c8d788deb/browser/components/migration/ChromeProfileMigrator.sys.mjs#148
|
|
Reporter | |
Comment 4•1 year ago
|
||
Steven will be fixing this in bug 1815543.
Description
•