1815767 - shippable-l10n-pre completely ignores browser/locales/l10n-changesets.json

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P1)

Description

[Rob Lemley [:rjl]]

While working on bug 1810727, I found that comm_desktop_l10n.py does not take browser/locales/l10n-changesets.json into account when cloning the l10n-central repositories. The "default" revision is always used.

It's surprising that no localization bugs have appeared as a result. (Yay cross-channel works!)

Affects beta and esr102.

Comment 1

[Rob Lemley [:rjl]]

Attachment: Bug 1815767 - strings from l10n-central are pulled with incorrect revision. r=#thunderbird-build-system-reviewers

In order for pull_locale_source() to retrieve the correct revisions from the
various l10n-central repositories, self.l10n_revisions needs to be populated
with the data in browser/locales/l10n-changesets.json. That file was never
read, so self.l10n_revisions was an empty dict. That being the case,
pull_locale_source() helpfully fell-back to using "default" as the revision.

The fix turns out to be pretty simple, calling self.parse_locales_file()
with browser/locales/l10n-changesets.json fills in self.l10n_revisions with
all of the revisions. Then pull_locale_source() works as expected.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cb65c61083d4
strings from l10n-central are pulled with incorrect revision. r=thunderbird-build-system-reviewers,dandarnell

Comment 3

[Rob Lemley [:rjl]]

Comment on attachment 9316653 [details]
Bug 1815767 - strings from l10n-central are pulled with incorrect revision. r=#thunderbird-build-system-reviewers

[Triage Comment]
Approved for 102.8.0, verified with wsmwk via Matrix.

Comment 4

[Rob Lemley [:rjl]]

Thunderbird 102.8.0:
https://hg.mozilla.org/releases/comm-esr102/rev/33dc8c524c94