1815799 - Fix fzf preview on Windows

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: image.png

See screenshot to what I see, both on msys and on mozillabuild.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1815799 - Remove unused run_cmd function in fzf.py. r=#build

Drive-by, while I was going through this code.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1815799 - Fix fzf preview on Windows. r=#build

fzf doesn't quote the preview command arguments, so if you have
windows-style paths given to a unix-style shell, the slashes are
completely gone.

This happens on multiple systems, both with MozillaBuild and external
MSYS2 shell.

fzf respects the SHELL environment variable, so to fix it, execute the
command using cmd.exe on Windows, via $COMSPEC.

Depends on D169264

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c15a3c17288
Remove unused run_cmd function in fzf.py. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/c4d83a6cced5
Fix fzf preview on Windows. r=firefox-build-system-reviewers,ahochheiden

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/7c15a3c17288
https://hg.mozilla.org/mozilla-central/rev/c4d83a6cced5