Improve search form handing in SearchEngine and improve docs for getSubmission
Categories
(Firefox :: Search, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
I noticed that when we get the search form via SearchEngine.getSubmission, we pass in the purpose - however for search form urls, the purpose never gets used as we don't use mozparams on search forms. Hence we can simplify the code a bit.
Additionally, the getSubmission documentation doesn't make it clear that if an empty string is passed, then the search form may be returned if it exists. Whilst we could change the behaviour, I think we shouldn't do that until we understand a bit more about search form in bug 1781766.
|
Assignee | |
Comment 1•1 year ago
|
||
Search forms have never had purposes, so we don't need to try to handle them as if they did have purposes.
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D169295
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/271cd55d91cf Simplify getting the search form for a search engine. r=search-reviewers,daleharvey https://hg.mozilla.org/integration/autoland/rev/9af3da406d7e Improve nsISearchEngine.getSubmission documentation. r=search-reviewers,daleharvey
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/271cd55d91cf
https://hg.mozilla.org/mozilla-central/rev/9af3da406d7e
Description
•