1815976 - Push notification is crashing the browser: Crash in [@ java.lang.IllegalStateException: at mozilla.components.lib.push.firebase.AbstractFirebasePushService.onMessageReceived(AbstractFirebasePushService.kt:145)]

Status: RESOLVED WORKSFORME

(Fenix :: Push, defect, P3)

Description

[alessandro]

Steps to reproduce:

Evry time i receive a push notification (not a normal notification)
Just to avoid confusion (even if such an explaination is not supposed to be need for a developer) with push notification i mean:
Browser tab closed(eg twitter)-----> notication arrives-----> browser crashes
heres the log
8b52e29-3a27-425d-9e49-cfbe2010b2a5java.lang.IllegalStateException: You need to call PushProcessor.install() on your Push instance from Application.onCreate().----java.lang.IllegalStateException: You need to call PushProcessor.install() on your Push instance from Application.onCreate().at mozilla.components.lib.push.firebase.AbstractFirebasePushService.onMessageReceived(AbstractFirebasePushService.kt:156)at com.google.firebase.messaging.FirebaseMessagingService.handleIntent(FirebaseMessagingService.java:786)at com.google.firebase.messaging.EnhancedIntentService$$ExternalSyntheticLambda1.run(R8$$SyntheticClass:11)at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)at com.google.android.gms.common.util.concurrent.zza.run(com.google.android.gms:play-services-basement@@18.1.0:7)at java.lang.Thread.run(Thread.java:920).
bug affect nighlty from 8 feb.

Actual results:

Push notifications should be received without crashing the browser

Expected results:

Fenix nighlty crash

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Chris Peterson [:cpeterson]]

Thanks for filing this bug report, Alessandro. I found a crash report that matches the crash you describe:

https://crash-stats.mozilla.org/report/index/963d7a5e-0995-499e-8c5f-4c5270230603

The crash volume is pretty low. I only see 4 crash reports from Firefox 113 and none since then.

java.lang.IllegalStateException: You need to call PushProcessor.install() on your Push instance from Application.onCreate().
	at mozilla.components.lib.push.firebase.AbstractFirebasePushService.onMessageReceived(AbstractFirebasePushService.kt:145)
	at com.google.firebase.messaging.FirebaseMessagingService.handleIntent(FirebaseMessagingService.java:789)
	at com.google.firebase.messaging.EnhancedIntentService$$ExternalSyntheticLambda1.run(R8$$SyntheticClass:11)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
	at com.google.android.gms.common.util.concurrent.zza.run(com.google.android.gms:play-services-basement@@18.1.0:7)
	at java.lang.Thread.run(Thread.java:784)

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since the crash volume is low (less than 15 per week), the severity is downgraded to S3. Feel free to change it back if you think the bug is still critical.

For more information, please visit BugBot documentation.

Comment 5

[Jonathan Almeida [:jonalmeida]]

No more crashes have shown up in the last 6 months.