1816041 - Re-enable and fix the "imapdeleted" variation of the message row (mark as deleted)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Alessandro Castellani [:aleca]]

With the "Mark a message as deleted" option in the settings, deleting a message doesn't mark it with the imapdeleted property.
Selecting the message again deletes it, but it shouldn't.

The trash icon (delete button) should be replaced with a "restore" button, and clicking on that should restore the message.

Some actions, like mark as unread, should be disabled.

Comment 1

[Magnus Melin [:mkmelin]]

Mark as read/unread and other status marking is unrelated to the deleted status, so they should remain enabled.
The restore button used to say "Undelete", which seems correct.

Comment 2

[[e-mail]]

Attachment: Bug 1816041 - Re-enable and fix the imapdeleted variation of the message row. r=aleca

Comment 3

[Alessandro Castellani [:aleca]]

Geoff, Micah is reimplementing the missing styling for the imapdeleted behavior, but we noticed that the message gets removed from the thread after a few seconds.
Any hint on why this is happening and what we're missing?

Comment 4

[Magnus Melin [:mkmelin]]

FWIW I use imap mark as delete for one of my accounts, and I haven't seen that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7b70ea423ff
Re-enable and fix the imapdeleted variation of the message row. r=aleca

Comment 6

[Wayne Mery (:wsmwk)]

Comment on attachment 9324898 [details]
Bug 1816041 - Re-enable and fix the imapdeleted variation of the message row. r=aleca

[Triage Comment]
Approved for beta

Comment 7

[Wayne Mery (:wsmwk)]

Should this fix the following?
Bug 1815096 - imap mark-as-deleted: doesn't advance to next on delete
Bug 1823186 - No Advance and delayed marking in Inbox after message delete in Beta 112.0b1, with mark as deleted

Comment 8

[Magnus Melin [:mkmelin]]

It doesn't.

Comment 9

[Daniel Darnell [:dandarnell]]

Thunderbird 112.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/0d6b2a3e08e1