Closed Bug 1816073 Opened 1 year ago Closed 1 year ago

The Device Manager window has increased height

Categories

(Firefox :: Settings UI, defect, P3)

Desktop
All
defect

Tracking

()

VERIFIED FIXED
112 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox109 --- unaffected
firefox110 --- wontfix
firefox111 --- verified
firefox112 --- verified

People

(Reporter: atrif, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image image.png

Found in

  • 111.0a1 (20230209213208)

Affected versions

  • 111.0a1 (20230209213208)
  • 110.0RC1

Tested platforms

  • Affected platforms: Windows 10x64, macOS 12, Ubuntu 20.04
  • Unaffected platforms: none

Steps to reproduce

  1. Open Firefox and about:preferences#privacy.
  2. Scroll down to the Certificates section and click on Security Devices.
  3. Observe the opened window.

Expected result

  • The content is aligned with the window.

Actual result

  • The window has increased height leaving a blank space at the bottom.

Regression range

Additional notes

  • Attached a screenshot.
Priority: -- → P3

Hmm, I don't recall why I changed this min-height by a height, I didn't
write it down in the commit message either :/

This doesn't regress bug 1801607 and fixes the issue, so should be safe.

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b96f1b7620b
Allow device manager height to grow again. r=settings-reviewers,Gijs
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

Verified fixed with Firefox 112.0a1 (20230214093302) on Windows 10x64, macOS 12 and Ubuntu 20.04. The Device Manager window is correctly displayed.

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emilio)

Comment on attachment 9317375 [details]
Bug 1816073 - Allow device manager height to grow again. r=mconley

Beta/Release Uplift Approval Request

  • User impact if declined: comment 0
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: comment 0 (would be worth testing the other certificate sections since they share styles)
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Relatively trivial css change that reverts a line.
  • String changes made/needed: none
  • Is Android affected?: No
Flags: needinfo?(emilio)
Attachment #9317375 - Flags: approval-mozilla-beta?
Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Comment on attachment 9317375 [details]
Bug 1816073 - Allow device manager height to grow again. r=mconley

Approved for 111.0b2

Attachment #9317375 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Verified fixed with Firefox 111.0b2 (20230215211409) from comment 8 on Windows 10x64, macOS 15 and Ubuntu 20.04. The Device manager is correctly displayed. Also, I looked out at the Certificate Manager window, and it looks good.

QA Whiteboard: [qa-triaged]
Flags: qe-verify+
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: