1816108 - [wpt-sync] Sync PR 38446 - Set the "previous" page name when setting up the fragment builder.

Status: RESOLVED FIXED

(Core :: Layout, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38446 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38446
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Set the "previous" page name when setting up the fragment builder.

Every in-flow child, when adding its fragment to the builder, will
propagate its page name to the builder, so that the builder can keep
track of the previous (or current) page name.

The decision whether to break before a child due to a page name change
is made by essentially comparing the page name of the fragment (that
we're considering to add to the builder) with the previous page name
stored in the builder. Normally this check won't be performed on the
first in-flow child, since there's usually no break opportunity there -
breaks are inserted between siblings, not between a parent and its
child.

However, if there's a class C breakpoint before the first in-flow child,
due to a float, we're going to perform this check at the first, and then
it's important that the builder knows the page name. Without this fix,
we'd detect a page name change (from nothing to "foo" - see the test
included), and insert a break before the first in-flow child.

Bug: 1414718
Change-Id: If7d85f7b0e611f5a5d570de586126b0534478c4b
Reviewed-on: https://chromium-review.googlesource.com/4238838
WPT-Export-Revision: d92a182a32e41eaea908d3f2279a673d0f6d285a

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6a2b7e2f928f5fe914673e537c5ffe51b22459fd

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, and Chrome on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daf35fbb763c
[wpt PR 38446] - Set the "previous" page name when setting up the fragment builder., a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8408472dbb2e
[wpt PR 38446] - Set the "previous" page name when setting up the fragment builder., a=testonly

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8408472dbb2e