1816111 - The tags panel is cut off inside the Library window after clicking Show all tags button

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: tags_panel.gif

Found in

• 111.0a1 (20230209213208)

Affected versions

• 111.0a1 (20230209213208)

Tested platforms

• Affected platforms: Windows 10x64, macOS 12, Ubuntu 20.04
• Unaffected platforms: none

Steps to reproduce

1. Open Firefox > App Menu > History > Manage History.
2. Select a random history item.
3. Click on the Show all tags button and observe the window.

Expected result

• The expanded Tags panel is correctly displayed inside the Library window.

Actual result

• The expanded Tags panel is cut off.

Regression range

• Last good revision: 6d37ee664b922e926a686feba165b20a628626e3
  First bad revision: 62fd688e335958ef1e95328d7bab329be8ad3a0f
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6d37ee664b922e926a686feba165b20a628626e3&tochange=62fd688e335958ef1e95328d7bab329be8ad3a0f

Additional notes

• Attached a screen recording.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1816111 - Use min-height rather than height in the places details pane. r=mak,dao,Gijs

That is, allow it to grow if something makes it take more space (like
the all tags text box). This works with and without flexbox emulation.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31f31e098c0d
Use min-height rather than height in the places details pane. r=Gijs

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/31f31e098c0d

Comment 4

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 111.0a1 (20230213092225) on Windows 10x64, macOS 12 and Ubuntu 20.04. The Tags panel is no longer clipped when expanded.