Closed Bug 1816134 Opened 1 year ago Closed 1 year ago

<datalist> creates a dropdown when tied to <input type="range">

Categories

(Toolkit :: Form Manager, defect, P2)

Firefox 111
defect

Tracking

()

VERIFIED FIXED
113 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- wontfix
firefox111 --- wontfix
firefox112 --- wontfix
firefox113 --- verified

People

(Reporter: ana.tudor.lhnh, Assigned: serg)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [fxcm-debt])

Attachments

(3 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/111.0

Steps to reproduce:

  1. Create a range input with a datalist tied to it:
<div role='group' aria-label='slider with ruler'>
	<input type='range' list='l'/>
	<datalist id='l'>
		<option value='0' label='0'></option>
		<option value='50' label='50'></option>
		<option value='100' label='100'></option>
	</datalist>
</div>
  1. Make the datalist a 3 column grid in order to create a ruler with labels made out of the options for the slider:
datalist {
	display: grid;
	grid-template-columns: repeat(5, 2em)
}
  1. At first, all seems fine.

Actual results:

But when dragging the slider to change the value from a value without an option[label] corespondent to one with an option[label] correspondent, we get a dropdown covering the rendered option elements making up the slider ruler.

Live test https://codepen.io/thebabydino/pen/poZXqQO

Expected results:

The dropdown should not appear in this case as the datalist is not tied to a text or search input, but to a range one. This is what happens in Chromium browsers.

The Bugbug bot thinks this bug should belong to the 'Core::Disability Access APIs' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Disability Access APIs
Product: Firefox → Core

Now we support tick marks for the native rendering, not showing the popup probably makes sense.

Component: Disability Access APIs → Layout: Form Controls
Blocks: input-range
Assignee: nobody → zach
Status: NEW → ASSIGNED

Looks like it's not only range controls: Buttons, checkboxes, and radio buttons also show a popup as of 2c8ff4622a78 (see testcase Non-text controls that show a suggestions popup). I think only single-line text controls are expected to show a popup.

Assignee: zach → nobody
Status: ASSIGNED → NEW
Component: Layout: Form Controls → Form Manager
Product: Core → Toolkit
Regressed by: 1767250
Severity: -- → S3
Flags: needinfo?(sgalich)
Priority: -- → P2

Set release status flags based on info from the regressing bug 1767250

:issammani, since you are the author of the regressor, bug 1767250, could you take a look?

Flags: needinfo?(imani)
Assignee: nobody → sgalich
Status: NEW → ASSIGNED
Attachment #9323127 - Attachment description: Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers → WIP: Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers
Attachment #9323127 - Attachment description: WIP: Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers → Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers
Attachment #9323127 - Attachment description: Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers → WIP: Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers
Attachment #9323127 - Attachment description: WIP: Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers → Bug 1816134 - show datalist in autocomplete for text controls only r=#credential-management-reviewers
Depends on: 1823115
Flags: needinfo?(sgalich)
Whiteboard: [fxcm-debt]
Depends on: 1823123
Pushed by sgalich@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72307e7cda84
show datalist in autocomplete for text controls only r=credential-management-reviewers,dimi
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

The patch landed in nightly and beta is affected.
:serg, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox112 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(sgalich)
Flags: needinfo?(sgalich)
Flags: qe-verify+

Reproduced the initial issue described in comment 0 using an old Nightly before the fix, verified that using latest Firefox 113.0b8 across platforms (macOS 13, Ubuntu 22.04 and Windows 10) the dropdown with the values are no longer displayed when changing the input.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: