Reload the page when closing the toolbox if "disable javascript" was set
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(Not tracked)
People
(Reporter: jdescottes, Unassigned)
References
Details
When closing the toolbox, the "disable javascript" option should no longer apply. We already flip back the flag on the browsing context, however to properly apply this change, we should also reload the page.
It might be unexpected to reload the current page when closing the toolbox.
For comparison, Chrome is not reloading the page at any point when enabling or disabling the feature.
|
||
Comment 1•2 years ago
|
||
I don't think reloading page upon closing devtools (with JS turned off) is intuitive and might irrecoverably trash all alterations user did to page before closing devtools that they intended to preserve.
Any potentially destructive action must be clearly communicated and/or demand confirmation.
Fact that currently change of the "Disable JavaScript" pref also reloads the page without neither mentioning it in its tooltip nor asking for confirmation is clearly wrong, but vaguely excusable -- because the pref makes most (yet not all) sense for freshly loaded page, so it can be understood as a convenient shortcut to that state that developer's intuition probably expects, since they would have to reload the page anyway in the vast majority of the use cases.
But closing devtools does not seem like a clear or intuitive signal for refreshing entire page.
In other words, when I close the devtools, I expect no side effects, no HTTP requests that could potentially fail and trash the page I'm looking at.
|
Reporter | |
Comment 2•2 years ago
|
||
I agree that reloading without any notification would be counter-intuitive here.
One option would be to make the "reload" behavior optional, behind another flag, similar as to what we do for RDM.
Or we can show a notification when closing devtools if "Disable javascript" was enabled.
Finally we could align to chrome and stop reloading at all.
Vote for disable auto reload or add another option for reloading.
In some cases, need to load page normally, and then disable JS to debug subsequent interactions.
Description
•