1816339 - Revert mIsBookmarksObserver to false when stoping observation

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Daisuke Akatsuka (:daisuke)]

This is to fix a regression of bug 1678629.
I removed a logic that changed mIsBookmarksObserver to false in this revision by my mistake.
We need to revert it.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1816339: Revert mIsBookmarksObserver to false when stoping observation

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2e6be21decc
Revert mIsBookmarksObserver to false when stoping observation r=mak

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment 4

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/b2e6be21decc

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9317257 [details]
Bug 1816339: Revert mIsBookmarksObserver to false when stoping observation

Beta/Release Uplift Approval Request

• User impact if declined: We have not received any reports yet, but potentially the bookmark library window etc will come to work not properly.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is only one line and it affects only the ui for bookmarks.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9317257 [details]
Bug 1816339: Revert mIsBookmarksObserver to false when stoping observation

Approved for 111.0b2

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8e7bb4ab1fd9