1816443 - Determine the correct platform for clang based static-analysis

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Right now for macos we don't detect the correct platform, since we don't differentiate between arm64 and x64. This is undesirable since arm64 platforms will use x64 binaries.

Comment 1

[Andi [:andi]]

Attachment: Bug 1816443 - Use auto-bootstrap code to bootstrap clang-tidy in both bootstrap and code-analysis.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5353e36b8465
Use auto-bootstrap code to bootstrap clang-tidy in both bootstrap and code-analysis. r=andi,firefox-build-system-reviewers

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5353e36b8465

Comment 4

[Ryan Hunt [:rhunt]]

This commit broke clang-format for me. I would get the following error when trying to run ./mach clang-format. Backing out this change fixed it for me and allowed clang-tidy/format to be installed into .mozbuild.

I'm running on a M1 Macbook.

Error running mach:

    ['static-analysis', 'install']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file static-analysis| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

FileNotFoundError: [Errno 2] No such file or directory: '/Users/rhunt/.mozbuild/clang-tools/clang-tidy/bin/clang-format'

  File "/Users/rhunt/src/mz/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 1024, in install
    rc, _ = get_clang_tools(
  File "/Users/rhunt/src/mz/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 1580, in get_clang_tools
    return get_clang_tools(
  File "/Users/rhunt/src/mz/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 1602, in get_clang_tools
    return 0 if _is_version_eligible(command_context, clang_paths) else 1, clang_paths
  File "/Users/rhunt/src/mz/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 512, in _is_version_eligible
    current_version = _get_current_version(command_context, clang_paths)
  File "/Users/rhunt/src/mz/python/mozbuild/mozbuild/code_analysis/mach_commands.py", line 482, in _get_current_version
    subprocess.check_output(cmd, stderr=subprocess.STDOUT)
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/subprocess.py", line 415, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/subprocess.py", line 493, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/Users/rhunt/src/mz/third_party/python/sentry_sdk/sentry_sdk/integrations/stdlib.py", line 190, in sentry_patched_popen_init
    rv = old_popen_init(self, *a, **kw)  # type: ignore
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/subprocess.py", line 858, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/Applications/Xcode.app/Contents/Developer/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/subprocess.py", line 1704, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)

Comment 5

[Mike Hommey [:glandium]]

Please file a separate followup bug.

Comment 6

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #5)

Please file a separate followup bug.

Filed bug 1819784.