1816458 - New wpt failures in /css/css-transitions/properties-value-inherit-001.html due to transition events on explicitly inherited properties

Status: NEW

(Core :: CSS Transitions and Animations, defect, P3)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Syncing wpt PR 38464 found new untriaged test failures in CI

Tests Affected

Firefox-only failures

• /css/css-transitions/properties-value-inherit-001.html [wpt.fyi]
  • vertical-align length(pt) / events: FAIL
  • vertical-align length(pc) / events: FAIL
  • vertical-align length(px) / events: FAIL
  • vertical-align length(em) / events: FAIL
  • vertical-align length(ex) / events: FAIL
  • vertical-align length(mm) / events: FAIL
  • vertical-align length(cm) / events: FAIL
  • vertical-align length(in) / events: FAIL
  • vertical-align percentage(%) / events: FAIL

CI Results

Gecko CI (Treeherder)
GitHub PR Head

Notes

These updates will be on mozilla-central once bug 1816376 lands.

Note: this bug is for tracking fixing the issues and is not
owned by the wpt sync bot.

This bug is linked to the relevant tests by an annotation in
https://github.com/web-platform-tests/wpt-metadata. These annotations
can be edited using the wpt interop dashboard
https://jgraham.github.io/wptdash/

If this bug is split into multiple bugs, please also update the
annotations, otherwise we are unable to track which wpt issues are
already triaged. Resolving as duplicate or closing this issue should
be cause the bot to automatically update or remove the annotation.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

It seems we fail all the events tests of consistently, so in a sense this isn't a new failure. But it seems something is wrong either with the test or our transitionend events. Hiro / Birtles, maybe you can check?

Comment 2

[Brian Birtles (:birtles)]

That test is a maze. It appears to be testing the opposite of what the comments say. Chrome fails them all too, but for different reasons.

Those legacy transitions tests need to be completely rewritten or simply discarded.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: an example what the test does

I tend to agree with Brian. That said, I am quite unsure what the test wanted to test actually.

So for example here's a failure message;

assert_equals: Expected TransitionEnd events triggered on .transition expected "" but got "background-color:2s"

.transition' is a class name for a child element having a transition longhand. And its parent container is also has a transition longhand. And the test does change a CSS property of the parent container and the CSS property is the transition target, and the child has inherit. And looks like the test expected that the inherit` style child will never have transitions?

I am attaching an example to replicate what the test does. You can see there appear two CSS transitions both on the parent and child elements in devtools. I can also see two transitions on Chrome but the behavior looks odd.