Closed Bug 1816535 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 38475 - view-transition: Handle display:none on documentElement.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38475 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38475
Details from upstream follow.

Vladimir Levin <vmpstr@chromium.org> wrote:

view-transition: Handle display:none on documentElement.

display:none on the documentElement causes it to not generate a
LayoutObject. The current code incorrectly assumes this can never
happen. This can happen during exit/entry navigations.

For cases where documentElement->GetLayoutObject disappears during
a transition, we detect that by checking if we have any target_elements
in the list.

R=bokan@chromium.org, khushalsagar@chromium.org

Fixed:1410303
Change-Id: I1e065877088fe368e4aa717b816fb08c70560029
Reviewed-on: https://chromium-review.googlesource.com/4246977
WPT-Export-Revision: 5ce5611680f8dbccf47db53e06a1de38d4f99359

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS : 2
FAIL : 1

Chrome

CRASH: 3

Safari

PASS : 2
FAIL : 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6b2d57a5eb32 [wpt PR 38475] - view-transition: Handle display:none on documentElement., a=testonly https://hg.mozilla.org/integration/autoland/rev/64c257aa6f86 [wpt PR 38475] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/89c7fdc2b096 [wpt PR 38475] - view-transition: Handle display:none on documentElement., a=testonly https://hg.mozilla.org/integration/autoland/rev/600e3abf63a1 [wpt PR 38475] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/89c7fdc2b096
https://hg.mozilla.org/mozilla-central/rev/600e3abf63a1

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.