Open Bug 1816631 Opened 3 years ago Updated 3 years ago

JS::TraceEdge documentation comment is misleading about updating hashtables

Categories

(Core :: JavaScript: GC, defect, P3)

Product:
Core
Component:
JavaScript: GC
Type:
defect

Tracking

()

People

(Reporter: jonco, Unassigned)

References

(Blocks 1 open bug)

Details

The comment here suggests that hashtables can be effectively updated using TraceEdge and removing/readding elements. That's no longer the best way to do this and doesn't work for nursery allocated keys:

https://searchfox.org/mozilla-central/source/js/public/TracingAPI.h#333-339

The comment here is a long way out of date too: https://searchfox.org/mozilla-central/source/js/public/GCAPI.h#997-1003

Blocks: GC
Severity: -- → S4
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.