1816682 - Transpile CallClassHook

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P2)

Description

[Jan de Mooij [:jandem]]

CallClassHook is one of the few CacheIR instructions we don't transpile yet. My bound function rewrite prototype uses class hooks for bound function calls so we should just fix this.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1816682 part 1 - Add testing function and tests for JSClass call/construct hooks. r?iain!

newObjectWithCallHook() returns an object that's callable because it has call/construct
hooks. These hooks return a new object with information about the arguments passed to the
call, so that we can write tests for this more easily.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1816682 part 2 - Transpile CallClassHook. r?iain!

This adds an MCallBase base class that's shared with MCall. This lets us
reuse some of the MCall code for MCallClassHook.

Depends on D170070

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/46a9548d4831
part 1 - Add testing function and tests for JSClass call/construct hooks. r=iain
https://hg.mozilla.org/integration/autoland/rev/3afd6d54fc75
part 2 - Transpile CallClassHook. r=iain

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/46a9548d4831
https://hg.mozilla.org/mozilla-central/rev/3afd6d54fc75