1816685 - Let cleanup_writable await to propagate errors in WPT fs tests

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P3)

Description

[Jari Jalkanen [:jari]]

In test
testing/web-platform/tests/fs/FileSystemFileHandle-sync-access-handle-writable-lock.https.tentative.worker.js
the check

await promise_rejects_dom(
-    t, 'NoModificationAllowedError', cleanup_writable(t, await fileHandle.createWritable()));

fails because the otherwise correct error does not get caught by promise_rejects_dom.

If await before fileHandle.createWritable() is removed, the exception is caught as expected.

Comment 1

[Jari Jalkanen [:jari]]

Attachment: Bug 1816685 - Let cleanup_writable await to propagate errors in WPT fs tests. r=#dom-storage

Depends on D169833

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6ab7a8b9026
Let cleanup_writable await to propagate errors in WPT fs tests. r=dom-storage-reviewers,jesup

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b6ab7a8b9026

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38907 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot