Switch `test-manifest-alpha` linter to use an exclude list of manifests
Categories
(Developer Infrastructure :: Lint and Formatting, task)
Tracking
(Not tracked)
People
(Reporter: ahal, Unassigned, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=python])
The test-manifest-alpha linter has a yaml file of manifests, where if they fail, the issue will become an error rather than a warning. This allows us to do a gradual migration of manifests rather than needing to fix them all at once.
However, it would be slightly better if instead of listing the manifests that were good, it listed the manifests that were bad. This way, new manifests will automatically get linted.
To solve this bug, I'd recommend:
- Adjust the logic in the linter so that manifests listed in the
tools/lint/test-manifest-alpha/error-level-manifests.ymlturn issues into a warning (and the default is error). Also rename the file towarning-level-manifests.yml. - Run
./mach lint -l test-manifest-alpha -f unixand use scripts or coreutils to parse out the list of manifests that have failures. Then add them to thewarning-level-manifests.ymlfile.
|
||
Updated•3 years ago
|
Hey! I am looking for a good first bug. I have never contributed before and this is very new to me.
I read all the documentation and setup everything on my side. Can you assign this bug to me?
|
Reporter | |
Comment 2•3 years ago
|
||
Hello ianiket23, sorry for the delayed response! Yes please feel free to work on this, typically we'll assign the bug once we see a patch attached. Please let me know if you have any questions, you can reach out on https://matrix.to/#/#lint:mozilla.org as well.
|
||
Comment 3•3 months ago
|
||
Looks like we removed this linter at some stage.
Description
•