Closed Bug 1816804 Opened 1 year ago Closed 1 year ago

<spacebar> to scroll message content down (for longer emails) doesn’t activate automatically.

Categories

(Thunderbird :: Message Reader UI, defect, P2)

Thunderbird 111

Tracking

(thunderbird_esr102 unaffected, thunderbird111+ fixed, thunderbird112+ affected)

RESOLVED FIXED
112 Branch
Tracking Status
thunderbird_esr102 --- unaffected
thunderbird111 + fixed
thunderbird112 + affected

People

(Reporter: mkmelin, Assigned: darktrojan)

References

(Blocks 2 open bugs)

Details

(Keywords: regression, Whiteboard: [Supernova3p])

Attachments

(2 files)

<spacebar> to scroll message content down (for longer emails) doesn’t activate automatically. <spacebar> to scroll works if first mousing into the message content to give focus(?). It used to be directly available, so one could navigate e.g. using N for next unread, then read top of message and <spacebar> to see the lower part.

On Mac, clicking first in the message doesn't help.

Are most of the message click/select/focus issues highly related? If so, it would be a good win to get a bunch of them fixed in one shot.

(In reply to Wayne Mery (:wsmwk) from comment #1)

On Mac, clicking first in the message doesn't help.

Are most of the message click/select/focus issues highly related? If so, it would be a good win to get a bunch of them fixed in one shot.

This list incudes Bug 1816741 - Right-click on unselected row in message list fails to select it, then context menu action gets applied to random previously selected message(s), or context menu won't show if no selection

There's a test for this one, browser_spacehit.js, that is still disabled too, if somebody gets to it before me.

This bug is about the behaviour when mail.advance_on_spacebar is false, correct? Because what pressing the spacebar does when it's true doesn't work either, and that's what I thought the bug was about when I failed to read it properly this morning.

Whatever, both need fixing anyway so I'll do that.

Assignee: nobody → geoff
Status: NEW → ASSIGNED

If we don't override the variable, it points to the window object of the displayed message, and in about:3pane content also refers to it.
This is more useful than having them point to two different things.

Target Milestone: --- → 112 Branch

This is on the short list of things we most need next for shipping to more users. => P1
Super common workflow

Severity: -- → S3
Priority: -- → P2

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/dc2dbea784ff
Stop overriding content variable in about:message. r=mkmelin
https://hg.mozilla.org/comm-central/rev/f026c29ccf46
Restore the behaviour of pressing the space bar in mail tabs. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/d050035c4df2
follow-up - Fix some references to the wrong thing. rs=bustage-fix DONTBUILD

Comment on attachment 9318036 [details]
Bug 1816804 - Stop overriding content variable in about:message. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta - note the follow up bustage patch

Flags: needinfo?(daniel)
Attachment #9318036 - Flags: approval-comm-beta+

Comment on attachment 9318037 [details]
Bug 1816804 - Restore the behaviour of pressing the space bar in mail tabs. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Attachment #9318037 - Flags: approval-comm-beta+
Flags: needinfo?(daniel)
Whiteboard: [Supernova] → [Supernova3p]
See Also: → 1856654
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: