1816863 - [loong64] Fix `MacroAssembler::branchTruncateDoubleToInt32` on LoongArch64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Zhao Jiazhong]

Patch in bug 1810728 wrongly implemented the MacroAssembler::branchTruncateDoubleToInt32 function for loong64 port, and need to fix it for some out-of-int32-range cases.

Comment 1

[Zhao Jiazhong]

Attachment: Bug 1816863 - [loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem

Now only out-of-int64-range values will fail, which actually should be out-of-int32-range values.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1810728

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6aebef10c1cb
[loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6aebef10c1cb

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:zhaojiazhong-hf, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Zhao Jiazhong]

Comment on attachment 9317805 [details]
Bug 1816863 - [loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem

Beta/Release Uplift Approval Request

• User impact if declined: JavaScript code may go wrong on LoongArch64 platform.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is a fix that only affect LoongArch64 platform.
• String changes made/needed:
• Is Android affected?: No

Comment 7

[Donal Meehan [:dmeehan]]

Comment on attachment 9317805 [details]
Bug 1816863 - [loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem

Approved for 111.0b3

Comment 8

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/680d21409b5a