Closed Bug 1816863 Opened 1 year ago Closed 1 year ago

[loong64] Fix `MacroAssembler::branchTruncateDoubleToInt32` on LoongArch64

Categories

(Core :: JavaScript Engine: JIT, defect)

Other
Unspecified
defect

Tracking

()

RESOLVED FIXED
112 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox110 --- unaffected
firefox111 --- fixed
firefox112 --- fixed

People

(Reporter: zhaojiazhong-hf, Assigned: zhaojiazhong-hf)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Patch in bug 1810728 wrongly implemented the MacroAssembler::branchTruncateDoubleToInt32 function for loong64 port, and need to fix it for some out-of-int32-range cases.

Blocks: 1757272
Regressed by: 1810728

Now only out-of-int64-range values will fail, which actually should be out-of-int32-range values.

Assignee: nobody → zhaojiazhong-hf
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Set release status flags based on info from the regressing bug 1810728

Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6aebef10c1cb
[loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch

The patch landed in nightly and beta is affected.
:zhaojiazhong-hf, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(zhaojiazhong-hf)

Comment on attachment 9317805 [details]
Bug 1816863 - [loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem

Beta/Release Uplift Approval Request

  • User impact if declined: JavaScript code may go wrong on LoongArch64 platform.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This change is a fix that only affect LoongArch64 platform.
  • String changes made/needed:
  • Is Android affected?: No
Flags: needinfo?(zhaojiazhong-hf)
Attachment #9317805 - Flags: approval-mozilla-beta?

Comment on attachment 9317805 [details]
Bug 1816863 - [loong64] Fix 'branchTruncateDoubleToInt32' for some out-of-int32-range cases. r=jandem

Approved for 111.0b3

Attachment #9317805 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: