1816898 - comm Perma docshell/test/unit/test_allowJavascript.js | xpcshell return code: 0

Status: RESOLVED FIXED

(Thunderbird :: Upstream Synchronization, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: martin [at] humanoids.be
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=405711493&repo=comm-central
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/QUAHgAwmTo2bGqjOkVGvbQ/runs/0/artifacts/public/logs/live_backing.log

---

ERROR Unexpected exception TypeError: can't access property "wrappedJSObject", this.contentWindow is null at resource://test/AllowJavascriptChild.sys.mjs:7
receiveMessage@resource://test/AllowJavascriptChild.sys.mjs:7:9

Comment 1

[Intermittent Failures Robot]

46 failures in 729 pushes (0.063 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 46

Platform and build breakdown:

• linux1804-64-qr: 9
  • debug: 4
  • opt: 5
• linux1804-64-shippable-qr: 5
  • opt: 5
• windows10-64-2004-qr: 6
  • debug: 3
  • opt: 3
• windows10-32-2004-qr: 7
  • debug: 4
  • opt: 3
• macosx1015-64-qr: 7
  • opt: 4
  • debug: 3
• windows10-32-2004-shippable-qr: 3
  • opt: 3
• windows10-64-2004-shippable-qr: 4
  • opt: 4
• macosx1015-64-shippable-qr: 5
  • opt: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-15&endday=2023-02-15&tree=all

Comment 2

[Intermittent Failures Robot]

27 failures in 710 pushes (0.038 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 27

Platform and build breakdown:

• macosx1015-64-qr: 6
  • opt: 3
  • debug: 3
• linux1804-64-qr: 6
  • debug: 3
  • opt: 3
• windows10-64-2004-qr: 3
  • opt: 1
  • debug: 2
• windows10-32-2004-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 3
  • opt: 3
• windows10-32-2004-shippable-qr: 2
  • opt: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-16&endday=2023-02-16&tree=all

Comment 3

[Intermittent Failures Robot]

24 failures in 707 pushes (0.034 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 24

Platform and build breakdown:

• macosx1015-64-qr: 6
  • debug: 3
  • opt: 3
• linux1804-64-qr: 5
  • debug: 2
  • opt: 3
• linux1804-64-shippable-qr: 3
  • opt: 3
• macosx1015-64-shippable-qr: 3
  • opt: 3
• windows10-64-2004-qr: 4
  • opt: 2
  • debug: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-17&endday=2023-02-17&tree=all

Comment 4

[Intermittent Failures Robot]

109 failures in 3856 pushes (0.028 failures/push) were associated with this bug in the last 7 days.

This is the #6 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 109

Platform and build breakdown:

• linux1804-64-qr: 22
  • debug: 10
  • opt: 12
• linux1804-64-shippable-qr: 11
  • opt: 11
• windows10-64-2004-qr: 15
  • debug: 8
  • opt: 7
• windows10-32-2004-qr: 13
  • debug: 7
  • opt: 6
• macosx1015-64-qr: 21
  • opt: 11
  • debug: 10
• windows10-32-2004-shippable-qr: 7
  • opt: 7
• windows10-64-2004-shippable-qr: 8
  • opt: 8
• macosx1015-64-shippable-qr: 12
  • opt: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-13&endday=2023-02-19&tree=all

Comment 5

[Intermittent Failures Robot]

32 failures in 444 pushes (0.072 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 32

Platform and build breakdown:

• linux1804-64-qr: 7
  • opt: 4
  • debug: 3
• macosx1015-64-qr: 8
  • debug: 4
  • opt: 4
• windows10-32-2004-qr: 4
  • debug: 3
  • opt: 1
• windows10-64-2004-qr: 6
  • debug: 3
  • opt: 3
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-20&endday=2023-02-20&tree=all

Comment 6

[Intermittent Failures Robot]

28 failures in 625 pushes (0.045 failures/push) were associated with this bug yesterday.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. **

Repository breakdown:

• comm-central: 28

Platform and build breakdown:

• linux1804-64-qr: 5
  • opt: 3
  • debug: 2
• macosx1015-64-qr: 6
  • opt: 3
  • debug: 3
• windows10-64-2004-qr: 4
  • opt: 2
  • debug: 2
• windows10-32-2004-qr: 4
  • opt: 2
  • debug: 2
• windows10-64-2004-shippable-qr: 2
  • opt: 2
• macosx1015-64-shippable-qr: 3
  • opt: 3
• linux1804-64-shippable-qr: 3
  • opt: 3
• windows10-32-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-21&endday=2023-02-21&tree=all

Comment 7

[Geoff Lankow (:darktrojan)]

Julian, you added this part of the test. Any idea why it would be failing on Thunderbird only? Some preference, perhaps?

Comment 8

[Julian Descottes [:jdescottes]]

No idea, it seems to throw around:

  await page.loadURL("http://example.org/?other");

  await assertLoadFired(
    bc,
    undefined,
    "top BC with scripts disabled after navigation"
  );

which is not directly related to what I want to test.

I use the loadURL helper:

  async loadURL(url, redirectUrl = undefined) {
    await this.browserReady;

    this.browser.fixupAndLoadURIString(url, {
      triggeringPrincipal: Services.scriptSecurityManager.getSystemPrincipal(),
    });
    return promiseBrowserLoaded(this.browser, url, redirectUrl);
  }

I wonder if the browsing context gets replaced after this navigation on TB?

Could you try to add a bc = page.browsingContext; at L276 in this test and see if this helps (I don't have a dev environment setup for thunderbird, sorry :/)

Comment 9

[Martin Giger [:freaktechnik]]

Adding that does fix the test.

Comment 10

[Julian Descottes [:jdescottes]]

Thanks for checking I can ask for a quick review

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1816898 - Fix docshell/test/unit/test_allowJavascript.js for thunderbird

The browsing context might be replaced after the navigation

Comment 12

[Intermittent Failures Robot]

28 failures in 764 pushes (0.037 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 28

Platform and build breakdown:

• linux1804-64-qr: 6
  • opt: 4
  • debug: 2
• windows10-32-2004-qr: 4
  • debug: 3
  • opt: 1
• macosx1015-64-qr: 6
  • debug: 3
  • opt: 3
• windows10-64-2004-qr: 4
  • debug: 2
  • opt: 2
• linux1804-64-shippable-qr: 3
  • opt: 3
• macosx1015-64-shippable-qr: 3
  • opt: 3
• windows10-64-2004-shippable-qr: 1
  • opt: 1
• windows10-32-2004-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-22&endday=2023-02-22&tree=all

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d780b3bf959
Fix docshell/test/unit/test_allowJavascript.js for thunderbird r=nika

Comment 14

[Intermittent Failures Robot]

17 failures in 769 pushes (0.022 failures/push) were associated with this bug yesterday.

Repository breakdown:

• comm-central: 17

Platform and build breakdown:

• linux1804-64-qr: 4
  • opt: 2
  • debug: 2
• macosx1015-64-qr: 4
  • debug: 2
  • opt: 2
• windows10-64-2004-qr: 1
  • opt: 1
• windows10-32-2004-qr: 3
  • opt: 1
  • debug: 2
• linux1804-64-shippable-qr: 2
  • opt: 2
• windows10-32-2004-shippable-qr: 1
  • opt: 1
• windows10-64-2004-shippable-qr: 1
  • opt: 1
• macosx1015-64-shippable-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-23&endday=2023-02-23&tree=all

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/0d780b3bf959

Comment 16

[Intermittent Failures Robot]

105 failures in 3643 pushes (0.029 failures/push) were associated with this bug in the last 7 days.

This is the #3 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **

Repository breakdown:

• comm-central: 105

Platform and build breakdown:

• linux1804-64-qr: 22
  • opt: 13
  • debug: 9
• macosx1015-64-qr: 24
  • debug: 12
  • opt: 12
• windows10-32-2004-qr: 15
  • debug: 10
  • opt: 5
• windows10-64-2004-qr: 15
  • debug: 7
  • opt: 8
• linux1804-64-shippable-qr: 10
  • opt: 10
• windows10-64-2004-shippable-qr: 6
  • opt: 6
• macosx1015-64-shippable-qr: 9
  • opt: 9
• windows10-32-2004-shippable-qr: 4
  • opt: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-02-20&endday=2023-02-26&tree=all

Comment 17

[Intermittent Failures Robot]

2 failures in 3578 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 2

Platform and build breakdown:

• macosx1015-64-qr: 2
  • debug: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1816898&startday=2023-05-15&endday=2023-05-21&tree=all