1816915 - Animation handling on bind / unbind is rather suspect.

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

In bug 1807003 I'm adding some comments for broken things.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1816915 - Clean up EffectSet APIs. r=#firefox-animation-reviewers

EffectSet::GetEffectSet seems rather redundant, use just EffectSet::Get
and tweak naming of similar APIs.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1816915 - Tweak how we handle animation restyles on bind/unbind. r=#firefox-animation-reviewers

Remove code on bind/unbind that requested a restyle on an unstyled
element, and that canceled that on an unbound element.

Instead, deal with detached nodes in EffectCompositor.

Tweak test restyles since we now expect one restyle as a result of the
initial composing of the animation that before happened eagerly.

Drive-by remove an unused test function in wpt (animationStartsRightNow
is not defined there anyways).

In practice, this makes it consistent with how we handle bind on
elements in shadow trees.

Depends on D169931

Comment 3

[Emilio Cobos Álvarez [:emilio]]

What's the

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ca6d14cd94c8
Clean up EffectSet APIs. r=firefox-animation-reviewers,boris

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/ca6d14cd94c8

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0b7a696e466
Tweak how we handle animation restyles on bind/unbind. r=hiro

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38614 for changes under testing/web-platform/tests

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/a0b7a696e466

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot