1816988 - Consider enabling layout.forms.reveal-password-context-menu.enabled

Status: VERIFIED FIXED

(Firefox :: Menus, enhancement, P1)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1816988 - Enable reveal password context-menu. r=sgalich

It seems there are no UX concerns or what not about this.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3539271beba
Enable reveal password context-menu. r=sgalich

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c3539271beba

Comment 4

[Pascal Chevrel:pascalc (PTO until April 26)]

I think we could have a release note about it as this is exposing a new useful feature in the UI, emilio would you have a suggested wording? Thanks

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Something like this?

Release Note Request (optional, but appreciated)
[Why is this notable]: Nice user-exposed feature.
[Affects Firefox for Android]: No
[Suggested wording]: Right-clicking on password fields now shows an option to reveal the password.

Comment 6

[Pascal Chevrel:pascalc (PTO until April 26)]

Looks good to me thanks! Note added to our nightly release notes.

Comment 7

[Alexandru Trif, Desktop QA [:atrif]]

Attachment: password_contextr.gif

Verified that layout.forms.reveal-password-context-menu.enabled pref is set to true in Firefox 112.0 on Windows 10x64, macOS 11, and Ubuntu 20.04. Also, the Reveal Password context menu option is displayed inside the password field for saved and not saved passwords while they are masked and works accordingly when used by showing/masking passwords.

However, I noticed that are some websites that already have this function and it seems that they don't communicate with each other. For example, when using the context menu option to unmask the password the webpage's unmask password does not change and the button does not function anymore. Is this expected or should we file an issue for this? Thank you!

Comment 8

[Emilio Cobos Álvarez (:emilio)]

That is expected

Comment 9

[Alexandru Trif, Desktop QA [:atrif]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)

That is expected

Thank you!