1817005 - [wpt-sync] Sync PR 38523 - Revert "Generate canvas layer global state tests with new test variants feature."

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 38523 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38523
Details from upstream follow.

John Abd-El-Malek <[e-mail]> wrote:

Revert "Generate canvas layer global state tests with new test variants feature."

This reverts commit 446ce8aea96e6d4696d9702c1ac86861c9c8cdf6.

Reason for revert: causes failures on mac11-arm64-rel-tests e.g.

https://ci.chromium.org/p/chromium/builders/ci/mac11-arm64-rel-tests/13707

Original change's description:

Generate canvas layer global state tests with new test variants feature.

All of these tests were very similar with the only important different
being the global state applied in the setup. Adding a "variant" feature
to the test generation script allows for cutting a lot of this
repetitive code.

Change-Id: Ic3ac63e80ff9c5290ae5f98a29c7d854951e9ba7
Bug: 1409873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209308
Reviewed-by: Aaron Krajeski \<[e-mail]>
Commit-Queue: Jean-Philippe Gravel \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1105685}

Bug: 1409873
Change-Id: I7ff8878e3ad2c7ebb980390035897a9651d88339
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4255276
Commit-Queue: John Abd-El-Malek \<[e-mail]>
Bot-Commit: Rubber Stamper \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1105772}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 38523 applied with additional changes from upstream: 44fdb6b93fecab82c052fa687368ec2ef28e444a, 63548ad3ecae3fad9e9dcc7c2c5962a5c33ccb39, e00b1606589c1f5ef7e3de052b6507dd19e90108, df22633a4118c2baaeaead8e05c202744d23ab92

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=727044a87b9912b9af8608f1776eecee084322d1

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests

Status Summary

Firefox

FAIL : 11
TIMEOUT: 1

Chrome

PASS : 12

Safari

FAIL : 11
TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/layers/2d.layer.alpha.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-alpha-filter-globalcompositeoperation.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-alpha-filter-shadow.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-alpha-filter.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-alpha-shadow.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-filter-globalcompositeoperation.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-filter-shadow.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-filter.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-globalcompositeoperation.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/element/manual/layers/layers-shadow.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/layers/2d.layer.alpha.html [wpt.fyi]: FAIL (Chrome: PASS, Safari: FAIL)
• /html/canvas/offscreen/layers/2d.layer.alpha.w.html [wpt.fyi]: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/902938463bf8
[wpt PR 38523] - Revert "Generate canvas layer global state tests with new test variants feature.", a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e26b16602dbc
[wpt PR 38523] - Revert "Generate canvas layer global state tests with new test variants feature.", a=testonly

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e26b16602dbc