1817020 - Optimize NVDA behaviour for onboarding spotlights & feature callouts on Windows

Status: RESOLVED FIXED

(Firefox :: Messaging System, task, P2)

Description

[Emily McMinn :emcminn]

+++ This bug was initially created as a clone of Bug #1795811 +++

From @ayeddi on bug 1795811:
Only tab key works for navigation - arrow keys are not doing anything on these particular pages. This is not expected... And Up/Down arrows work with NVDA on other page as expected, so this is the Onboarding experience's bug and not a user error as you mentioned. I am not sure if it is related, but I was not able to do the right click press on the page too (I am not concerned about it though)

The subtitle (that is made as <h2>) is not announced when the page is being announced on load. You can only hear it when hovering over. Note: the entire page is only being announced when the page is opened initially, as mentioned above, arrow keys do nothing thus read-all mode is not working. Another item not being announced is the image (only on hover)

The above issues were found during verification for Bug 1795811. I think part of the issue is we are using the same component for the about:welcome onboarding, the upgrade spotlight (a modal) and the Feature Callouts. Currently the parent element has a role of alertdialog . Adding role="document" to the inner element seems to work well for the about:welcome pages, but not for the spotlight or callouts.
(It does seem to make the Spotlight content accessible via the arrow keys, once browse mode is activated manually with NVDA+space, I'm just not sure this is the right behaviour for these kinds of dialogs.)

Jamie, Anna, do you have any thoughts on what the best practice would be here? I've attached a tentative patch with the role="document" applied; I'm curious if the difference in behaviour between the three types of content (about:welcome, spotlight modal, feature callout) is acceptable.

Comment 1

[Emily McMinn :emcminn]

Attachment: Bug 1817020 - Add "document" role to MultiStageProtonScreen to trigger read-all for NVDA

Comment 2

[James Teh [:Jamie]]

Anna is on leave until May.

I know how to access about:welcome, but can you tell me how to test the spotlight and callouts? I'm not familiar with those.

Comment 3

[Emily McMinn :emcminn]

(In reply to James Teh [:Jamie] from comment #2)

Anna is on leave until May.

I know how to access about:welcome, but can you tell me how to test the spotlight and callouts? I'm not familiar with those.

Hi Jamie! Upgrade Spotlight can be accessed by opening the browser toolbox console and pasting in the following command:
Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog() (If you don't have the browser toolbox available in the tools menu, you can enable it by checking "Enable browser chrome and add-on debugging toolboxes" in the advanced settings of the regular devtools.)

The easiest way to trigger the callouts is to start a new profile and open the Firefox View tab, which will show you the Firefox View feature tour. You should be able to reset the tour and see it again by setting browser.firefox-view.feature-tour to a value of {"screen":"FIREFOX_VIEW_SPOTLIGHT","complete":false} in about:config. EDIT: I had the wrong value for the pref. It should work now!
Hope that helps! Thanks for taking a look :)

Comment 4

[James Teh [:Jamie]]

Sorry for the delay.

1. about:welcome looks good to me.
2. I think the upgrade dialog would ideally be treated as a document, so the document role should go inside the dialog.
3. The tour is a dialog inside a document, so it is already treated as a document. However, when you press one of the buttons, the dialog loses focus; focus lands elsewhere in the Firefox View document. Focus should remain in the dialog somewhere; e.g. on the dialog itself or the Next button.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf066a983f8b
Add "document" role to MultiStageProtonScreen to trigger read-all for NVDA r=Jamie

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cf066a983f8b