1817103 - Remove or update probes expiring in Firefox 113: WEBEXT_EVENTPAGE_IDLE_RESULT_COUNT* before Gecko version gets increased to 113 on 2023-03-13

Status: RESOLVED FIXED

(WebExtensions :: General, task, P2)

Description

[telemetry-probes]

The following Firefox probes will expire in the next major Firefox nightly release: version 113 [1].

WEBEXT_EVENTPAGE_RUNNING_TIME_MS_BY_ADDONID
WEBEXT_EVENTPAGE_IDLE_RESULT_COUNT
WEBEXT_EVENTPAGE_IDLE_RESULT_COUNT_BY_ADDONID

What to do about this:

1. If one, some, or all of the metrics are no longer needed, please remove them from their definitions files (Histograms.json, Scalars.yaml, Events.yaml).
2. If one, some, or all of the metrics are still required, please submit a Data Collection Review [2] and patch to extend their expiry. There is a shorter form for data collection renewal [3].

If you have any problems, please ask for help on the #data-help Slack channel or the #telemetry Matrix room at https://chat.mozilla.org/#/room/#telemetry:mozilla.org. We'll give you a hand.

Your Friendly, Neighborhood Telemetry Team

[1] https://wiki.mozilla.org/Release_Management/Calendar
[2] https://wiki.mozilla.org/Firefox/Data_Collection
[3] https://github.com/mozilla/data-review/blob/master/renewal_request.md

This is an automated message sent from probe-scraper. See https://github.com/mozilla/probe-scraper for details.

Comment 1

[Rob Wu [:robwu]]

Luca, could you bump them to 122, so that their expiration is aligned with most of our other probes that we recently extended in bug 1811155?

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Sure thing, I had the same thought and I was already planning to sync the next expire version to the same one we used for those.

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

test_ext_webRequest_eventPage_StreamFilter.js tests for this.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: bug1817103_data_renewal_request.md

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1817103 - Renew WebExtensions event page telemetry histograms. r?willdurand!

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1817103 - Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r?willdurand!

Depends on D171112

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1817103 - Remove expired histogram EXTENSION_UPDATE_TYPE. r?willdurand!

Depends on D171113

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1817103 - Remove expired Scalar extensions.updates.rdf. r?willdurand!

Depends on D171114

Comment 9

[Chris H-C :chutten]

Comment on attachment 9320060 [details]
bug1817103_data_renewal_request.md

DATA REVIEW RESPONSE:

Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?

Yes.

Is the data collection covered by the existing Firefox Privacy Notice?

Yes.

---

Result: datareview+

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a733796a149
Renew WebExtensions event page telemetry histograms. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/5bd9691b0306
Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/90c134a0e92c
Remove expired histogram EXTENSION_UPDATE_TYPE. r=willdurand
https://hg.mozilla.org/integration/autoland/rev/ae6e9421f7bb
Remove expired Scalar extensions.updates.rdf. r=willdurand

Comment 11

[Iulian Moraru]

Backed out for causing bc failures on browser_extension_sideloading.js.

• Push with failures

• Failure log

• Backout link

[task 2023-03-02T12:49:03.404Z] 12:49:03     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_extension_sideloading.js | Incognito checkbox should not be hidden - 
[task 2023-03-02T12:49:03.405Z] 12:49:03     INFO - Buffered messages finished
[task 2023-03-02T12:49:03.407Z] 12:49:03     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/webextensions/browser_extension_sideloading.js | ["sideloadRejected","sideloadAccepted","sideloadAccepted"] deepEqual [] - {"filename":"chrome://mochitests/content/browser/browser/base/content/test/webextensions/head.js","name":"expectTelemetry","sourceId":622,"lineNumber":694,"columnNumber":10,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":{"filename":"chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_extension_sideloading.js","name":"test_sideloading","sourceId":623,"lineNumber":319,"columnNumber":18,"sourceLine":"","asyncCause":null,"asyncCaller":null,"caller":null,"formattedStack":"test_sideloading@chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_extension_sideloading.js:319:18\n","nativeSavedFrame":{}},"formattedStack":"expectTelemetry@chrome://mochitests/content/browser/browser/base/content/test/webextensions/head.js:694:10\ntest_sideloading@chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_extension_sideloading.js:319:18\n","nativeSavedFrame":{}}
[task 2023-03-02T12:49:03.407Z] 12:49:03     INFO - Stack trace:
[task 2023-03-02T12:49:03.407Z] 12:49:03     INFO - chrome://mochitests/content/browser/browser/base/content/test/webextensions/head.js:expectTelemetry:694
[task 2023-03-02T12:49:03.407Z] 12:49:03     INFO - chrome://mochitests/content/browser/browser/base/content/test/webextensions/browser_extension_sideloading.js:test_sideloading:319
[task 2023-03-02T12:49:03.408Z] 12:49:03     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_extension_sideloading.js | Should no longer have addon alert badge - 
[task 2023-03-02T12:49:03.409Z] 12:49:03     INFO - GECKO(6340) | [Child 6406: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7facee214800 == 5 [pid = 6406] [id = 1] [url = moz-extension://fb17d4d1-02c7-4b75-9bfb-9331f30f4964/_generated_background_page.html]
[task 2023-03-02T12:49:03.410Z] 12:49:03     INFO - GECKO(6340) | [Child 6406: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 17 (7facf3281850) [pid = 6406] [serial = 3] [outer = 0] [url = moz-extension://fb17d4d1-02c7-4b75-9bfb-9331f30f4964/_generated_background_page.html]
[task 2023-03-02T12:49:03.412Z] 12:49:03     INFO - GECKO(6340) | [WARN  rkv::backend::impl_safe::environment] `load_ratio()` is irrelevant for this storage backend.
[task 2023-03-02T12:49:03.617Z] 12:49:03     INFO - GECKO(6340) | [Parent 6340, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:163
[task 2023-03-02T12:49:03.618Z] 12:49:03     INFO - GECKO(6340) | [Parent 6340, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp:163
[task 2023-03-02T12:49:03.624Z] 12:49:03     INFO - Test telemetry events collected for addon1
[task 2023-03-02T12:49:03.627Z] 12:49:03     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_extension_sideloading.js | Got the expected telemetry event - {"method":"sideload_prompt","object":"extension","value":"[e-mail]","extra":{"num_strings":"2","source":"app-profile","method":"sideload"}} deepEqual {"object":"extension","extra":{"source":"app-profile","method":"sideload","num_strings":"2"},"value":"[e-mail]","method":"sideload_prompt"} - 
[task 2023-03-02T12:49:03.629Z] 12:49:03     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_extension_sideloading.js | Got the expected telemetry event - {"method":"uninstall","object":"extension","value":"[e-mail]","extra":{"source":"app-profile","method":"sideload"}} deepEqual {"object":"extension","extra":{"source":"app-profile","method":"sideload"},"value":"[e-mail]","method":"uninstall"} - 
[task 2023-03-02T12:49:03.630Z] 12:49:03     INFO - TEST-PASS | browser/base/content/test/webextensions/browser_extension_sideloading.js | Got the expected number of telemetry events for addon1 - 

Comment 12

[Phabricator Automation]

Comment on attachment 9320065 [details]
Bug 1817103 - Remove expired Scalar extensions.updates.rdf. r?willdurand!

Revision D171115 was moved to bug 1819940. Setting attachment 9320065 [details] to obsolete.

Comment 13

[Phabricator Automation]

Comment on attachment 9320063 [details]
Bug 1817103 - Remove expired histogram EXTENSION_UPDATE_TYPE. r?willdurand!

Revision D171114 was moved to bug 1819940. Setting attachment 9320063 [details] to obsolete.

Comment 14

[Phabricator Automation]

Comment on attachment 9320062 [details]
Bug 1817103 - Remove expired histogram EXTENSION_INSTALL_PROMPT_RESULT. r?willdurand!

Revision D171113 was moved to bug 1819940. Setting attachment 9320062 [details] to obsolete.

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Iulian Moraru from comment #11)

Backed out for causing bc failures on browser_extension_sideloading.js.

That looks definitely a failure due to one of the expired probes being removed (I think that is likely to be related to EXTENSION_INSTALL_PROMPT_RESULT), the test is likely covering that telemetry without going through the actual unified telemetry internal and so it did not fail when the probe actually expired.

I'm moving the 3 patches that remove expired probe into a different bugzilla issue (Bug 1819940) and I'll push to autoland again the patch renewing the expiring probes actually tracked by this bug (which was most definitely not the one triggering the unexpected failure).

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6363834bcdbc
Renew WebExtensions event page telemetry histograms. r=willdurand

Comment 17

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/6363834bcdbc