1817251 - Record telemetry for History in sidebar and library when using the context menu

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P1)

Description

[Sarah Clements [:sclements]]

Bug 1815706 and bug 1815906 adds additional telemetry to the history sidebar and library window, but Leif's identified a few other history and bookmark surfaces that we should add probes to:

1. Main menu (App menu) history - total number of history entries opened per session
2. Single click of history item in sidebar and library via context menu
3. Library icon (NavBar) - total number of history entries opened per session

See Leif's inventory doc ("surface key/screenshots "tab) for clarity on each of these surfaces: https://docs.google.com/spreadsheets/d/1Q4_vfTSmv0nysbFLe88VJSiUrRjI0rnO1UFTRRK1OBA/edit#gid=2111169208

Comment 1

[Kelly Cochrane [:kcochrane]]

Should we maybe consider breaking out the bookmark-specific telemetry into its own ticket given the title of this ticket?

Comment 2

[Sarah Clements [:sclements]]

(In reply to Kelly Cochrane [:kcochrane] from comment #1)

Should we maybe consider breaking out the bookmark-specific telemetry into its own ticket given the title of this ticket?

If the patch already seems like it's becoming large, or if you'd just prefer to break bookmarks out separately, that's fine with me (or keep it as is and change the title).

Comment 3

[Kelly Cochrane [:kcochrane]]

I haven't begun work on this yet, but given we just discovered we'll also need to add telemetry for when opening Library/Sidebar links using the context menu, I think we may want to break out Bookmark work separately.

Comment 4

[Sarah Clements [:sclements]]

I've broken bookmarks telemetry into its own bug 1819081.

Comment 5

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 1817251 - Record telemetry for History in sidebar and library when using the context menu r=sclements,mak

Comment 6

[Kelly Cochrane [:kcochrane]]

Attachment: Firefox View Data Collection Request.txt

Comment 7

[Chris H-C :chutten]

Comment on attachment 9322159 [details]
Firefox View Data Collection Request.txt

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Kelly Cochrane is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 8

[Kelly Cochrane [:kcochrane]]

After discussion with Sarah, we're going to handle adding new telemetry for History in the app menu and library navbar menu in a separate bug. Sarah discovered we have an existing keyed scalar being recorded in these areas (albeit recording them always as bookmarks rather than bookmarks and history items separately). So the sole purpose of this ticket will now be to record telemetry when opening history links in the History sidebar and Library window by using the context menu as it was not added as part of bug 1815706 and bug 1815906.

Comment 9

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9322159 [details]
Firefox View Data Collection Request.txt

Removing the data review flag given the comment above ^

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/855983630997
Record telemetry for History in sidebar and library when using the context menu r=sclements,mak

Comment 11

[Kelly Cochrane [:kcochrane]]

Comment on attachment 9320320 [details]
Bug 1817251 - Record telemetry for History in sidebar and library when using the context menu r=sclements,mak

Beta/Release Uplift Approval Request

• User impact if declined: History-specific telemetry will not be recorded when opening links from the context menu in the Library window and the History sidebar.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: N/A
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively small change to ensure telemetry is recorded as expected when using the context menu. Automated tests were added to ensure this works as expected.
• String changes made/needed: N/A
• Is Android affected?: No

Comment 12

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/855983630997

Comment 13

[Dianna Smith [:diannaS]]

Comment on attachment 9320320 [details]
Bug 1817251 - Record telemetry for History in sidebar and library when using the context menu r=sclements,mak

Approved for 112.0b3

Comment 14

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/79dcedd47884