Closed Bug 1817283 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 38554 - Revert "Reland "Generate canvas layer global state tests with new test variants feature.""

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 38554 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/38554
Details from upstream follow.

Jeffrey Cohen <jeffreycohen@chromium.org> wrote:

Revert "Reland "Generate canvas layer global state tests with new test variants feature.""

This reverts commit 0511f163d2d9ccba4a98deab26972b46f5f2d05e.

Reason for revert: Failing windows tests here https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10

Original change's description:

Reland "Generate canvas layer global state tests with new test variants feature."

This is a reland of commit 446ce8aea96e6d4696d9702c1ac86861c9c8cdf6,
with pixel fuzzy tolerance updated to account for the mac11-arm64-rel
builder.

Original change's description:

Generate canvas layer global state tests with new test variants feature.

All of these tests were very similar with the only important different
being the global state applied in the setup. Adding a "variant" feature
to the test generation script allows for cutting a lot of this
repetitive code.

Change-Id: Ic3ac63e80ff9c5290ae5f98a29c7d854951e9ba7
Bug: 1409873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4209308
Reviewed-by: Aaron Krajeski \<aaronhk@chromium.org>
Commit-Queue: Jean-Philippe Gravel \<jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1105685}

Bug: 1409873
Change-Id: I21eeeb2b1581097d37eaaa3fd41da159ffb02e0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4255729
Reviewed-by: Aaron Krajeski \<aaronhk@chromium.org>
Commit-Queue: Jean-Philippe Gravel \<jpgravel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1106242}

Bug: 1409873
Change-Id: I93c6c95354fc78d74876750a5924134d0daab1be
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4260694
Auto-Submit: Jeffrey Cohen \<jeffreycohen@chromium.org>
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1106352}

PR 38554 applied with additional changes from upstream: 44fdb6b93fecab82c052fa687368ec2ef28e444a, 63548ad3ecae3fad9e9dcc7c2c5962a5c33ccb39, e00b1606589c1f5ef7e3de052b6507dd19e90108, df22633a4118c2baaeaead8e05c202744d23ab92, 24ce9ca1f4959c0b14d1abb9b12ce35b58c68f99, 27ae5af35c48530aca3ba94823eafc570a2704bd
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 12 tests

Status Summary

Firefox

FAIL : 11
TIMEOUT: 1

Chrome

PASS : 12

Safari

FAIL : 11
TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d1b491c49a36 [wpt PR 38554] - Revert "Reland "Generate canvas layer global state tests with new test variants feature."", a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/229a1011ee42 [wpt PR 38554] - Revert "Reland "Generate canvas layer global state tests with new test variants feature."", a=testonly

https://hg.mozilla.org/mozilla-central/rev/229a1011ee42

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.