1817360 - Lazily load broken image icons.

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, task)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

With the patches of bug 1815229, these errors appear:

browser/base/content/test/performance/browser_startup_images.js | Loaded image resource://gre-resources/loading-image.png should have been shown

Looks like a legit bug!

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817360 - Clean-up image icon loading code. r=tnikkel

• Use static prefs.
• Move IconLoad to the cpp file since it's only used in one translation
  unit.

This is in preparation to make the image loads lazy.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817360 - Remove browser.display.show_loading_image_placeholder. r=tnikkel

This pref has been false since forever, completely untested, and I see
no references to it anywhere. I'm pretty sure having a loading image
placeholder wouldn't be web compatible, particularly in the current days
with all the lazy-loading shenanigans etc.

I propose just removing this code, and simplifying surrounding code for
clarity.

Depends on D170157

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1817360 - Lazily load broken image icon. r=tnikkel

With the patches of bug 1815229, these errors appear:

browser/base/content/test/performance/browser_startup_images.js | Loaded image resource://gre-resources/loading-image.png should have been shown

It's a real issue, where we eagerly load the broken image icon and so on
even though we don't use them.

This fixes it by lazily-loading the icon once, only when needed.

Depends on D170158

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f024e2fa75f
Clean-up image icon loading code. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/aff89f104ac9
Remove browser.display.show_loading_image_placeholder. r=tnikkel

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/484c8de8d2f5
Remove no-longer relevant exception from browser_startup_images.js

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4f024e2fa75f
https://hg.mozilla.org/mozilla-central/rev/aff89f104ac9
https://hg.mozilla.org/mozilla-central/rev/484c8de8d2f5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Does this still need to be open?

Comment 9

[Emilio Cobos Álvarez [:emilio]]

Yes, last patch still needs to land.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/735440c1b416
Lazily load broken image icon. r=tnikkel

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a18068f374df
Fix missing file in layout_reftests_with_caret.

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/735440c1b416
https://hg.mozilla.org/mozilla-central/rev/a18068f374df