Closed
Bug 1817426
Opened 2 years ago
Closed 2 years ago
Gutter check for Windows non-native menus should use media query instead of version check (missing gutter on about:downloads context menu in Windows 7/8)
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: Gijs, Assigned: Gijs)
References
Details
Attachments
(1 file)
https://searchfox.org/mozilla-central/rev/9de332d5c8faac58dc1232b8a6383ce6cb1400f4/toolkit/content/widgets/menupopup.js#14-34 was written when we only used these menus on Win10+. But that has changed, and so the condition needs updating so the gutter logic runs on Win7/Win8 as well if we're using the non-native menus there.
|
Assignee | |
Updated•2 years ago
|
Component: Theme → Themes
Product: Firefox → Toolkit
|
||
Comment 1•2 years ago
|
||
Any reason it can't be just unconditional?
|
|
Assignee | |
Comment 2•2 years ago
|
||
|
|
Assignee | |
Updated•2 years ago
|
Summary: Gutter check for Windows non-native menus should use media query instead of version check → Gutter check for Windows non-native menus should use media query instead of version check (missing gutter on about:downloads context menu in Windows 7/8)
|
|
Assignee | |
Comment 3•2 years ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)
Any reason it can't be just unconditional?
Hm. Well, the attribute is only used on Windows and I guess it's technically a perf hit for the other OSes?
Fixing that is possible but more work...
|
||
Updated•2 years ago
|
Attachment #9318401 -
Attachment description: Bug 1817426 - use feature detection instead of hardcoding version limits for Windows non-native menu gutter logic, r?emilio → Bug 1817426 - stop limiting toggling of 'needsgutter' attribute so Windows non-native menus with checkboxes look good on Win7/8, r?emilio
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f1786fab9d2d
stop limiting toggling of 'needsgutter' attribute so Windows non-native menus with checkboxes look good on Win7/8, r=emilio
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•