1817600 - Add affiliate banner to NordVPN

Status: RESOLVED FIXED

(SeaMonkey :: Website, enhancement)

Description

[RickieES aka Ricardo Palomares]

Attachment: Patch to add the banner and link to NordVPN to SeaMonkey website. Binary file is attached separately

NordVPN proposed SeaMonkey e.V. entering an affiliate program. Given that, apart from Duck Duck Go, we don't have any current sponsorships in place, SeaMonkey e.V. concluded trying it was a low risk experiment to earn some money for the project.

Although our idea was to display the banner only in main page under the menu, either I don't know enough the template system, or it is not possible, so the provided patch will display the banner in the entire site.

Comment 1

[RickieES aka Ricardo Palomares]

Attachment: nordvpn-banner.png

The banner image

Comment 2

[Frank-Rainer Grahl (:frg)]

Attachment: 1817600-nordvpn-sponsorshp.patch

hg formatted patch

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9319901 [details] [diff] [review]
1817600-nordvpn-sponsorshp.patch

Looks ok to me. Final verdict when it is on staging.

Comment 4

[Frank-Rainer Grahl (:frg)]

Does not show so fix needed:

https://gitlab.com/seamonkey-project/website/-/commit/971d01eaea8119caec032a064bfc7e664188769f

https://staging.seamonkey-project.org/

Comment 5

[Frank-Rainer Grahl (:frg)]

see comment 4

Comment 6

[RickieES aka Ricardo Palomares]

Attachment: Removed extra template directory

Image didn't show because of extra "/template" directory in path, it should work now (fingers crossed). I must be missing something in git diff command because I can't get the binary dump of png file to show up in the patch.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9319901 [details] [diff] [review]
1817600-nordvpn-sponsorshp.patch

Already checked into staging so just needs a diff patch on top.

Comment 8

[RickieES aka Ricardo Palomares]

Could you elaborate about the "diff patch on top" thing? Is it something that I must prepare? TIA

Comment 9

[Frank-Rainer Grahl (:frg)]

I tinkered a bit yesterday with IanN and it is on https://staging.seamonkey-project.org/ . Seems the image and link is filtered out as an advert by both uBlock and ABP. IanN and I think we do a text link and show a text partnership not "sponsorted by" link. Stay tuned.

Comment 10

[Frank-Rainer Grahl (:frg)]

RickieES tried a bit more to fix this but ran into a template issue. https://gitlab.com/seamonkey-project/website/-/tree/staging
Asked IanN for some advice.
Maybe you can take a look. Any patches best done against staging. When we have something working I will do a combined patch for r+.

Comment 11

[Ian Neal]

Attachment: 1817600-nordvpn.patch [Checked in: Comment 12]

Final version of patch

Comment 12

[Ian Neal]

Comment on attachment 9323819 [details] [diff] [review]
1817600-nordvpn.patch [Checked in: Comment 12]

https://gitlab.com/seamonkey-project/website/-/commit/971d01eaea8119caec032a064bfc7e664188769f
https://gitlab.com/seamonkey-project/website/-/commit/9cee18069513fe7731a139b8c579f0c5bfcc4998
https://gitlab.com/seamonkey-project/website/-/commit/712bc319c27b1374909605d021e6d14191db5f5a
https://gitlab.com/seamonkey-project/website/-/commit/150bf54ae7ba5cdd356029e739b69990dfaf6b1a
https://gitlab.com/seamonkey-project/website/-/commit/e6c9fc3598ad721d20b2dda47e7a42a474b7742c
https://gitlab.com/seamonkey-project/website/-/commit/8f0b07b857e8588565a4ff55428a5d96f56b297e
https://gitlab.com/seamonkey-project/website/-/commit/c1a00352b587a206a2fb8c3172acaab4a00a9456
https://gitlab.com/seamonkey-project/website/-/commit/296de50a597c22d1938bbfe7cefa75e806f9258d
https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/1e64aeb1849688a35910559656b7efa811c2e38a

Comment 13

[RickieES aka Ricardo Palomares]

Marking as fixed, as the banner went live five days ago. Thank you, Frank and Ian.

Comment 14

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9323819 [details] [diff] [review]
1817600-nordvpn.patch [Checked in: Comment 12]

Checked in some time ago and looks good.