1817820 - Fix race condition in marionette when switchFrame is called during a navigation

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect, P3)

Description

[Julian Descottes [:jdescottes]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1786640#c11

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We will determine the severity in our next triage meeting.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817820 - [marionette] WIP: retry switch to frame if browsing context changed mid flight

Just to illustrate the analysis, this fixes the issue. Let's discuss if we want to go for something along those lines

Comment 5

[Julian Descottes [:jdescottes]]

Given that this is a fix for Bug 1816061, let's close this as duplicate and move the patch to the appropriate bug

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Julian Descottes [:jdescottes] from comment #5)

Given that this is a fix for Bug 1816061, let's close this as duplicate and move the patch to the appropriate bug

Usually we want to use dedicated bugs for fixes, which also makes it easier to spot what needs to be added for release notes. So could we just add the dependency instead for the test failure on Android?

Comment 7

[Julian Descottes [:jdescottes]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #6)

(In reply to Julian Descottes [:jdescottes] from comment #5)

Given that this is a fix for Bug 1816061, let's close this as duplicate and move the patch to the appropriate bug

Usually we want to use dedicated bugs for fixes, which also makes it easier to spot what needs to be added for release notes. So could we just add the dependency instead for the test failure on Android?

Sure. I think we do it by default for single tracking bugs, not really for other intermittents.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1817820 - [marionette] Retry switch to frame if browsing context changed mid flight

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c739d1419fe
[marionette] Retry switch to frame if browsing context changed mid flight r=webdriver-reviewers,whimboo

Comment 10

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/6c739d1419fe