1817842 - "Add Security Exception" display problem

Status: VERIFIED FIXED

(Core :: Security: PSM, defect)

Description

[erosman]

Attachment: certificate1a.png

ref: Nightly 111?-112

For a while now (maybe within last 2 weeks), the Add Security Exception popup has CSS issues and the text runs off the popup, as per attached screenshots.

Settings -> Privacy & Security -> View Certificates... -> Add Exception...

Comment 1

[erosman]

Attachment: certificate2a.png

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Security: PSM' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Julien Cristau [:jcristau]]

Mozregression says:

7:57.95 INFO: No more integration revisions, bisection finished.
7:57.95 INFO: Last good revision: 2c05658add65ba2f7513b2a76fe32be80c7c86e6
7:57.95 INFO: First bad revision: 1432fd8955ce7ee78eab40753eb15ee274045919
7:57.95 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2c05658add65ba2f7513b2a76fe32be80c7c86e6&tochange=1432fd8955ce7ee78eab40753eb15ee274045919

Although the "good" case seems to be differently bad, i.e. the window is not tall enough and buttons are cut off.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I don't seem to be able to reproduce this locally on the latest Nightly, what distro can you repro this on, Ubuntu? That dialog has At a glance it seems like bug 1813960 should've addressed this as well.

Comment 5

[Julien Cristau [:jcristau]]

I'm on Debian, nightly 20230219095859, wayland/gnome.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1817842 - Tweak exception dialog styles.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I can reproduce with somewhat weird font settings using gnome-tweaks... Does comment 6 help for you?

Comment 8

[erosman]

I am on Ubuntu 22.10 Wayland & Nightly 112.0a1 (2023-02-20) (64-bit).
The screenshots were taken today.

Comment 9

[Pascal Chevrel:pascalc (PTO until April 26)]

FWIW, I am seeing the same bug, same OS config except that I use a French nightly.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Does this build help then? https://treeherder.mozilla.org/jobs?repo=try&revision=ef44c6702c48a1bf4054a79a7f0c290978ae3b8c

Comment 11

[Julien Cristau [:jcristau]]

Attachment: Screenshot from 2023-02-21 10-31-31.png

It does.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09a0cd5aea39
Tweak exception dialog styles. r=settings-reviewers,Gijs

Comment 13

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/09a0cd5aea39

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox111 to wontfix.

For more information, please visit auto_nag documentation.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9318810 [details]
Bug 1817842 - Tweak exception dialog styles.

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0 in some linux configurations
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple targeted patch.
• String changes made/needed: none
• Is Android affected?: No

Comment 16

[erosman]

Confirmed fixed in Build ID 20230224092408
Ubuntu 22.10 Wayland & Nightly 112.0a1 (2023-02-24) (64-bit)

Comment 17

[Donal Meehan [:dmeehan]]

Comment on attachment 9318810 [details]
Bug 1817842 - Tweak exception dialog styles.

Approved for 111.0b6

Comment 18

[Donal Meehan [:dmeehan]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4862dff4ed1d

Comment 19

[Alexandru Trif, Desktop QA [:atrif]]

Reproduced the issue with Firefox 112.0a1 (2023-02-19) on Ubuntu 22.04.2 LTS Wayland-Gnome by opening Settings -> Privacy & Security -> View Certificates... -> Add Exception... and adding one invalid or one valid webpage inside location field and pressing Get Certificate button. After the message is displayed the window content is clipped.
The issue is no longer reproducing with Firefox 111.0b6 and 112.0a1 (2023-02-28) on the same system. The Add Security exception window content is no longer clipped after pressing the Get Certificate button on a valid and invalid webpage.